From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59091)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1aQUzf-0006Wc-PX
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:03:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1aQUza-0000N3-Q0
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:03:19 -0500
References: <1454347206-23717-1-git-send-email-wei@redhat.com>
	<1454347206-23717-2-git-send-email-wei@redhat.com>
	<CAFEAcA9XZHowe_JtGFcqEJpnZiqXwT+36bBPPKXWSgc1aVGtHg@mail.gmail.com>
From: Michael Tokarev <mjt@tls.msk.ru>
Message-ID: <56B054A8.6020602@msgid.tls.msk.ru>
Date: Tue, 2 Feb 2016 10:03:04 +0300
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9XZHowe_JtGFcqEJpnZiqXwT+36bBPPKXWSgc1aVGtHg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for
 PL061 device state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Wei Huang <wei@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Igor Mammedov <imammedo@redhat.com>, Shannon Zhao <shannon.zhao@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Shannon Zhao <zhaoshenglong@huawei.com>

01.02.2016 21:01, Peter Maydell wrote:
> On 1 February 2016 at 17:20, Wei Huang <wei@redhat.com> wrote:
>> This patch removes float_high field of PL061State, which doesn't seem
>> to be used anywhere.
[]
>> @@ -88,7 +87,6 @@ static const VMStateDescription vmstate_pl061 = {
>>          VMSTATE_UINT32(slr, PL061State),
>>          VMSTATE_UINT32(den, PL061State),
>>          VMSTATE_UINT32(cr, PL061State),
>> -        VMSTATE_UINT32(float_high, PL061State),
>>          VMSTATE_UINT32_V(amsel, PL061State, 2),
>>          VMSTATE_END_OF_LIST()
> 
> This would be a migration compatibility break, so at a minimum
> you need to bump the vmstate struct versions.

Is it worth the effort to remove this field if it causes
compatibility break?  Maybe keep it around, it doesn't hurt?
At the very least, we may rename it to "unused_float_high",
or something, to indicate it is a known-unused?

Thanks,

/mjt