From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWHH-0002dZ-0f for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:25:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQWHD-0008B9-EY for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:25:34 -0500 References: <1454309636-18263-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1454309636-18263-2-git-send-email-caoj.fnst@cn.fujitsu.com> <56B0658A.20605@msgid.tls.msk.ru> From: Cao jin Message-ID: <56B0680C.8050200@cn.fujitsu.com> Date: Tue, 2 Feb 2016 16:25:48 +0800 MIME-Version: 1.0 In-Reply-To: <56B0658A.20605@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel@nongnu.org Cc: qemu-trivial , kraxel@redhat.com On 02/02/2016 04:15 PM, Michael Tokarev wrote: > 01.02.2016 09:53, Cao jin wrote: >> Signed-off-by: Cao jin >> --- >> hw/usb/ccid-card-emulated.c | 20 +++++++++----------- >> hw/usb/ccid.h | 4 ++++ >> 2 files changed, 13 insertions(+), 11 deletions(-) >> >> diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c >> index 869a63c..0b05260 100644 >> --- a/hw/usb/ccid-card-emulated.c >> +++ b/hw/usb/ccid-card-emulated.c >> @@ -42,8 +42,6 @@ do {\ >> } \ >> } while (0) >> >> -#define EMULATED_DEV_NAME "ccid-card-emulated" > > >> --- a/hw/usb/ccid.h >> +++ b/hw/usb/ccid.h >> +#define TYPE_EMULATED_CCID "ccid-card-emulated" >> +#define EMULATED_CCID_CARD(obj) \ >> + OBJECT_CHECK(EmulatedState, (obj), TYPE_EMULATED_CCID) > > Why did you move the type definition from .c to .h file? > It is only referenced in .c, no? > > Ditto for the second patch in this series. > > Thanks, > > /mjt > Yes, that type definition is referred only in .c for now, but we are not sure about it in the future, for better flexibility, I think put it into .h is better. http://wiki.qemu.org/QOMConventions also says: DO use TYPE_FOO constants, defined in a header if used in other parts of code -- Yours Sincerely, Cao jin