From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aQcGt-0004s6-KF
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 09:49:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aQcGp-0003tm-HU
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 09:49:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aQcGp-0003ta-Bv
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 09:49:31 -0500
References: <1447836791-369-1-git-send-email-eblake@redhat.com>
	<1447836791-369-25-git-send-email-eblake@redhat.com>
	<CAAG0J9-LPyiDun5M+ywa30KcEqrxR8XZzz7_vUdc_EDJU8VT0A@mail.gmail.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <56B0C1F9.5080604@redhat.com>
Date: Tue, 2 Feb 2016 07:49:29 -0700
MIME-Version: 1.0
In-Reply-To: <CAAG0J9-LPyiDun5M+ywa30KcEqrxR8XZzz7_vUdc_EDJU8VT0A@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="6Dc5cjk7KXlMC78weXegCihMTHqc3Fgid"
Subject: Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat
 union
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6Dc5cjk7KXlMC78weXegCihMTHqc3Fgid
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/02/2016 05:25 AM, James Hogan wrote:
> Hi Eric,
>=20
> On 18 November 2015 at 08:52, Eric Blake <eblake@redhat.com> wrote:
>> +# An enumeration of cpu types that enable additional information duri=
ng
>> +# @query-cpus.
>> +#
>> +# Since: 2.6
>> +##
>> +{ 'enum': 'CpuInfoArch',
>> +  'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'other' ] }
>> +

>=20
> This is causing compilation issues on MIPS, because gcc bizarrely
> defines mips=3D1:
>=20
> $ mips-img-linux-gnu-gcc -dM -E - </dev/null | grep '\bmips\b'
> #define mips 1

Not the first instance of namespace pollution.


> Any suggestions for a fix that is less ugly than this:

Yes, I'm posting the proper patch to poison QAPI 'mips' into C 'q_mips'
shortly.  That way, QMP remains backwards compatible (your approach did
not preserve that).

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--6Dc5cjk7KXlMC78weXegCihMTHqc3Fgid
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWsMH5AAoJEKeha0olJ0Nq0ycH/i7V9dVuZEg2n8xMI5Gttd2p
/WWdiaYVdAyhLOmJgtm1nUExJJtUA2oAnUxN9VvlZc/FbGWbRpC1/ubjEHffKjv4
vuGKE925lzJoCYnXgCDHap88cEK74nHn/xyqd0e+7TU+QUMTePNdkc+oTaPlI8in
BMmEQq0kzBWStApLy6YUO76rHmADG4U8EBIpIjvMbEf8RZZY399kelKMN4ynYYo3
SJ0uEwsJT1nK8SGsCN5emEgHA7US+cHvqVMhoKTnrVQdWvN0BRjjf0o4dgMjWOoY
jryZSptTAPNnjsonmHYY4pVJObag6ZEaEXQiEV1ds3JWvDA5w9TmA551Iq/AbFM=
=PY6G
-----END PGP SIGNATURE-----

--6Dc5cjk7KXlMC78weXegCihMTHqc3Fgid--