From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQfVL-0008CW-H3 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 13:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQfVI-0001B5-9A for qemu-devel@nongnu.org; Tue, 02 Feb 2016 13:16:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:41046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQfVI-0001Ay-3M for qemu-devel@nongnu.org; Tue, 02 Feb 2016 13:16:40 -0500 References: <1453804885-15544-1-git-send-email-kraxel@redhat.com> <1453804885-15544-4-git-send-email-kraxel@redhat.com> <87vb67kzde.fsf@blackfin.pond.sub.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56B0F286.9090206@suse.de> Date: Tue, 2 Feb 2016 19:16:38 +0100 MIME-Version: 1.0 In-Reply-To: <87vb67kzde.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , Gerd Hoffmann , qemu-devel@nongnu.org Am 02.02.2016 um 14:36 schrieb Markus Armbruster: > Gerd Hoffmann writes: >=20 >> This patch marks usb-bot as hot-pluggable device, makes attached >> property settable and turns off auto-attach in case the device >> was hotplugged. >> >> Hot-plugging a usb-bot device with one or more scsi devices can be >> done this way now: >> >> (1) device-add usb-bot,id=3Dfoo >> (2) device-add scsi-{hd,cd},bus=3Dfoo.0,lun=3D0 >> (2b) optionally add more devices (luns 0 ... 15). >> (3) qom-set foo.attached =3D true >=20 > This isn't exactly pretty, but it beats no hot plug. >=20 > A general solution for hot plugging composite devices could perhaps be > prettier, but I'm not aware of any recent work in the area. Andreas, > Paolo? Not aware, no. Essentially we'd need a DeviceClass::dont_realize flag, right? Then foo.attached=3Dtrue could become foo.realized=3Dtrue. Questio= n is then whether the bus would be attachable prior to realization - to be tested. Haven't read the full series yet, so puzzled what kind of bot this is supposed to be. ;) Cheers, Andreas >> Signed-off-by: Gerd Hoffmann >=20 > Assuming we want this because we can't have a general solution now: >=20 > Reviewed-by: Markus Armbruster --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)