From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aQgiS-0007IK-9F
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 14:34:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aQgiO-0002Bj-7J
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 14:34:20 -0500
References: <145442963048.1539.13602468921796488810.stgit@localhost>
	<145442965530.1539.10919507514033766738.stgit@localhost>
From: Eric Blake <eblake@redhat.com>
Message-ID: <56B104B4.7020307@redhat.com>
Date: Tue, 2 Feb 2016 12:34:12 -0700
MIME-Version: 1.0
In-Reply-To: <145442965530.1539.10919507514033766738.stgit@localhost>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="p3KXnxAVpx1bTvgTTclel9qGFUTIf62TW"
Subject: Re: [Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new
 error_report_abort() instead of abort()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, "open list:Overall" <kvm@vger.kernel.org>, Stefan Hajnoczi <stefanha@gmail.com>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, Alexander Graf <agraf@suse.de>, "open list:PowerPC" <qemu-ppc@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--p3KXnxAVpx1bTvgTTclel9qGFUTIf62TW
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/02/2016 09:14 AM, Llu=C3=ADs Vilanova wrote:
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  target-ppc/kvm.c        |    4 ++--
>  target-ppc/kvm_ppc.h    |   15 +++++++++------
>  target-ppc/mmu-hash32.c |    5 +++--
>  target-ppc/mmu_helper.c |    3 +--
>  4 files changed, 15 insertions(+), 12 deletions(-)
>=20

> @@ -215,36 +218,36 @@ static inline int kvmppc_get_htab_fd(bool write)
>  static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize=
,
>                                     int64_t max_ns)
>  {
> -    abort();
> +    error_report_abort(" ");
>  }

I still strongly dislike this.  Reporting an error message with nothing
but a trailing whitespace is NOT helpful.  Straight 'abort()' is better
than this; if we can't come up with a useful message, then it is not
worth using the message-handling interface.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--p3KXnxAVpx1bTvgTTclel9qGFUTIf62TW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWsQS0AAoJEKeha0olJ0NqSVMIALDjrxwnWjDCVYxSSznwDTtW
sPRkaIDmRa8jDHC67mUOPyo328FMriUmcugV7nslDzv6kw0VkAx+uyNeNMr014Fe
3r2q+kNnAVi3B2u+VRZs4lbHw3UmzKT2Ogd/tLfldKhDEyFn6BlNPzxZYg7tYRTI
Rt74H5JiGBQ+m5n1L8yV5IzMY3m8MeNujfQokBPMLrgptjroEXY1b6F2gg6SYo7z
3vn21S24UNgO+O83hGvDY6/M8+JtOVMw0CeG1RmGqy7CEf6b0W5hrwSerE8tZnXZ
YYt1Gua8CbF+2+4T0tAsdUPrUcisuJvNZRqx3l7AQuB062m5Y/5eeV/o1Pyk2zY=
=l7iU
-----END PGP SIGNATURE-----

--p3KXnxAVpx1bTvgTTclel9qGFUTIf62TW--