From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQiza-00059L-9l for qemu-devel@nongnu.org; Tue, 02 Feb 2016 17:00:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQizZ-0001TO-0U for qemu-devel@nongnu.org; Tue, 02 Feb 2016 17:00:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQizY-0001TI-SJ for qemu-devel@nongnu.org; Tue, 02 Feb 2016 17:00:08 -0500 References: <1454439920-14661-1-git-send-email-eblake@redhat.com> <877fimanft.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56B126E7.3090704@redhat.com> Date: Tue, 2 Feb 2016 15:00:07 -0700 MIME-Version: 1.0 In-Reply-To: <877fimanft.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HaCKNanSCcBiAdS1CLiI311kKPINu863j" Subject: Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , Michael Roth , Peter Crosthwaite , qemu-devel@nongnu.org, Luiz Capitulino , Paolo Bonzini , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HaCKNanSCcBiAdS1CLiI311kKPINu863j Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/02/2016 01:04 PM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Commit 86f4b687 broke compilation on sparc, which has a preprocessor >> pollution of '#define sparc 1'. Treat it the same way as we do for >> the pollution with 'unix', so that QMP remains backwards compatible >> and only the C code needs to use the alternative 'q_sparc' spelling. >> >> CC: Peter Maydell >> Signed-off-by: Eric Blake >> --- >> >> Done as a followup to the same style of patch for MIPS; or we could >> squash this into one patch. >=20 > Applied to qapi-next squashed: >=20 > qapi: Fix compilation failure on MIPS and SPARC > =20 > Commit 86f4b687 broke compilation on MIPS and SPARC, which have a > preprocessor pollution of '#define mips 1' and '#define space 1', s/space/sparc/ > respectively. Treat it the same way as we do for the pollution wit= h > 'unix', so that QMP remains backwards compatible and only the C cod= e > needs to use the alternative 'q_mips' spelling. > =20 > CC: James Hogan > CC: Peter Maydell > Signed-off-by: Eric Blake > Tested-by: James Hogan > Signed-off-by: Markus Armbruster >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HaCKNanSCcBiAdS1CLiI311kKPINu863j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWsSbnAAoJEKeha0olJ0NqqDYH/1OOgC9IqhUAtj9xfHZd+ZxI TpvWiUZvv7sKahi67IzyS9UVUyupSYHeD1ye0JodDX15yHnYJwAk1A/Q91jFX117 yrOmDjT8dWAVBH3gC1J6/Yafy3bW6Ow89m4SEYE/zyQcFMGMOEMHDx8vQeC0ZYYl +IK8+0LgOsWSZShzD844OyrkVR3bvOM3TOBAkvOG20DDgRk/qs6tt+HSsCG4EYYH wRouwcui7zTRSzNzH3aycd0vNpK+LgduED0cakYSyeb3ujinHgs25rtoF7dU7V6J rHr009Ayo/rp38aT8j3tHiNqoTJ6f7SlACccRcCMPrLA2nnNwPpmcFmPGQisLaM= =Hytw -----END PGP SIGNATURE----- --HaCKNanSCcBiAdS1CLiI311kKPINu863j--