From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQjBa-0002WR-49 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 17:12:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQjBW-0004Z2-RN for qemu-devel@nongnu.org; Tue, 02 Feb 2016 17:12:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQjBW-0004Yy-LJ for qemu-devel@nongnu.org; Tue, 02 Feb 2016 17:12:30 -0500 References: <1453963872-13549-1-git-send-email-vsementsov@virtuozzo.com> <1453963872-13549-3-git-send-email-vsementsov@virtuozzo.com> From: Eric Blake Message-ID: <56B129CC.4010005@redhat.com> Date: Tue, 2 Feb 2016 15:12:28 -0700 MIME-Version: 1.0 In-Reply-To: <1453963872-13549-3-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JU9D381WqAnEGdFjjtXVUUj5ESelEaFEP" Subject: Re: [Qemu-devel] [PATCH 2/3] pcdimm: add 'type' field to PCDIMMDeviceInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: Xiao Guangrong , "Michael S. Tsirkin" , Markus Armbruster , Stefan Hajnoczi , Igor Mammedov , "Denis V. Lunev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JU9D381WqAnEGdFjjtXVUUj5ESelEaFEP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: > The field is needed to distinguish pc-dimm and nvdimm. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Xiao Guangrong > CC: "Michael S. Tsirkin" > CC: Igor Mammedov > CC: Eric Blake > CC: Markus Armbruster > --- > +++ b/qapi-schema.json > @@ -3924,6 +3924,8 @@ > # > # @hotpluggable: true if device if could be added/removed while machin= e is running > # > +# @type: device type: 'pc-dimm' or 'nvdimm' (since 2.6) > +# > # Since: 2.1 > ## > { 'struct': 'PCDIMMDeviceInfo', > @@ -3934,7 +3936,8 @@ > 'node': 'int', > 'memdev': 'str', > 'hotplugged': 'bool', > - 'hotpluggable': 'bool' > + 'hotpluggable': 'bool', > + 'type': 'str' No. Since it is a finite set of values (just two possible), you should be using an enum here rather than open-coded 'str'. Something like: { 'enum': 'DIMMType', 'data': [ 'pc-dimm', 'nvdimm' ] } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JU9D381WqAnEGdFjjtXVUUj5ESelEaFEP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWsSnMAAoJEKeha0olJ0NqPmMH/2aUWbRnWaB0R2NNNKunDJe2 j4FxHxNzr5y4eEAlEsWTDHlmqhkuNQiXo3nB7dluye0b5xPvXfWFMuTbxxv3HRpP dBm54WOumLtiYa+6hHxnZdAEISX4H4BXxyhI9/XFVNdz0K9hX1l1R5PH4Ia2yBtB vTSWTl8EMJrFSRvJW6+NUxMhjc9TXGqDQWS0gr+7RHoL36HuQd7Gz+6QCLCNIIdd Ek4O3GkKzE4F041ChVtl5K4N1IuPVjdoZFgKIEkFZlTFDtIDFh1RZ1anoqoE2sR0 ESSjPNQWXalmsyxdxuhhyo8ZLoX8JZW5N5ryaQfaKmoNaiPPRdbyXpBCHfzvznQ= =g42z -----END PGP SIGNATURE----- --JU9D381WqAnEGdFjjtXVUUj5ESelEaFEP--