From: Laurent Vivier <laurent@vivier.eu>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues
Date: Wed, 3 Feb 2016 10:39:13 +0100 [thread overview]
Message-ID: <56B1CAC1.5040903@vivier.eu> (raw)
In-Reply-To: <1454492221-30625-3-git-send-email-glaubitz@physik.fu-berlin.de>
Le 03/02/2016 10:37, John Paul Adrian Glaubitz a écrit :
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
> target-m68k/translate.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 535d7f9..f508d1e 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2828,6 +2828,10 @@ register_opcode (disas_proc proc, uint16_t opcode, uint16_t mask)
> Later insn override earlier ones. */
> void register_m68k_insns (CPUM68KState *env)
> {
> + /* Build the opcode table only once to avoid
> + issues with multithreading. */
> + if(opcode_table[0] != NULL)
> + return;
> #define INSN(name, opcode, mask, feature) do { \
> if (m68k_feature(env, M68K_FEATURE_##feature)) \
> register_opcode(disas_##name, 0x##opcode, 0x##mask); \
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2016-02-03 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:36 [Qemu-devel] m68k: More bug fixes for translation code John Paul Adrian Glaubitz
2016-02-03 9:37 ` [Qemu-devel] [PATCH 1/2] m68k: Fix opcode mask for fbcc instruction John Paul Adrian Glaubitz
2016-02-03 9:38 ` Laurent Vivier
2016-02-08 23:13 ` John Paul Adrian Glaubitz
2016-02-03 9:40 ` John Paul Adrian Glaubitz
2016-02-03 9:42 ` Laurent Vivier
2016-02-03 9:37 ` [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues John Paul Adrian Glaubitz
2016-02-03 9:39 ` Laurent Vivier [this message]
2016-02-03 9:57 ` Laurent Vivier
2016-02-03 10:06 ` John Paul Adrian Glaubitz
2016-02-03 10:13 ` Laurent Vivier
2016-02-03 10:17 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1CAC1.5040903@vivier.eu \
--to=laurent@vivier.eu \
--cc=glaubitz@physik.fu-berlin.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).