From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQzB1-0008Fb-FV for qemu-devel@nongnu.org; Wed, 03 Feb 2016 10:17:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQzAr-0001wL-Vf for qemu-devel@nongnu.org; Wed, 03 Feb 2016 10:17:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQzAr-0001w6-Qb for qemu-devel@nongnu.org; Wed, 03 Feb 2016 10:16:53 -0500 References: <1454494453-20738-1-git-send-email-glaubitz@physik.fu-berlin.de> <1454494453-20738-2-git-send-email-glaubitz@physik.fu-berlin.de> From: Eric Blake Message-ID: <56B219E4.2070800@redhat.com> Date: Wed, 3 Feb 2016 08:16:52 -0700 MIME-Version: 1.0 In-Reply-To: <1454494453-20738-2-git-send-email-glaubitz@physik.fu-berlin.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iwhPK2anaSWRTdK2OFPW032MwEa0UnI2G" Subject: Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Paul Adrian Glaubitz , qemu-devel@nongnu.org Cc: laurent@vivier.eu This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iwhPK2anaSWRTdK2OFPW032MwEa0UnI2G Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/03/2016 03:14 AM, John Paul Adrian Glaubitz wrote: > Signed-off-by: John Paul Adrian Glaubitz = > --- > target-m68k/translate.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/target-m68k/translate.c b/target-m68k/translate.c > index 535d7f9..a989961 100644 > --- a/target-m68k/translate.c > +++ b/target-m68k/translate.c > @@ -2828,6 +2828,10 @@ register_opcode (disas_proc proc, uint16_t opcod= e, uint16_t mask) > Later insn override earlier ones. */ > void register_m68k_insns (CPUM68KState *env) > { > + /* Build the opcode table only once to avoid > + multithreading issues. */ > + if (opcode_table[0] !=3D NULL) > + return; Missing {}. Are you sure this is the version that passed checkpatch.pl? > #define INSN(name, opcode, mask, feature) do { \ > if (m68k_feature(env, M68K_FEATURE_##feature)) \ > register_opcode(disas_##name, 0x##opcode, 0x##mask); \ >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iwhPK2anaSWRTdK2OFPW032MwEa0UnI2G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWshnkAAoJEKeha0olJ0Nqid0IAKUQ4cCpVOiU5FeCiIBrOHtW ixXIvneLEBxXgqlvpAAg2rAdz97ZUVwprS/lBWxciEF3GtkJfpyCBSz6BnKGFJsd gYqPhF9qj8Q3+6PTocYgDPeAXPZ3VnigvlEIsqcZVuAxXG86+0hqt59wvRnZ+UWN kKuLG1TXrxfUSEbDkqx/gactQrFRh/bQsNouVSWozaO3SrXWwZMe3qHw9TAC+v9C Ja28J/b5VlXzMFi3wuEkPaKp81QQSHbMCm0C9OOcrMDQRtB97XAmsQ/KF+7qqxSc 7YOiXTb2IHAMQ3UifVwFyLHe5KBOAJR9UMWEhuy0OvQskfgMYJ4ZMLocX7B+s1M= =5qw3 -----END PGP SIGNATURE----- --iwhPK2anaSWRTdK2OFPW032MwEa0UnI2G--