From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration
Date: Wed, 3 Feb 2016 17:35:55 +0100 [thread overview]
Message-ID: <56B22C6B.9010401@redhat.com> (raw)
In-Reply-To: <1454464341-9494-2-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On 03.02.2016 02:52, Fam Zheng wrote:
> The "pnum < nb_sectors" condition in deciding whether to actually copy
> data is unnecessarily strict, and the qiov initialization is
> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
>
> Rewrite mirror_iteration to fix both flaws.
>
> The output of iotests 109 is updated because we now report the offset
> and len slightly differently in mirroring progress.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/mirror.c | 335 +++++++++++++++++++++++++++------------------
> tests/qemu-iotests/109.out | 80 +++++------
> trace-events | 1 -
> 3 files changed, 243 insertions(+), 173 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-03 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 1:52 [Qemu-devel] [PATCH v11 0/2] mirror: Improve zero write and discard Fam Zheng
2016-02-03 1:52 ` [Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration Fam Zheng
2016-02-03 16:35 ` Max Reitz [this message]
2016-02-03 17:33 ` Max Reitz
2016-02-03 1:52 ` [Qemu-devel] [PATCH v11 2/2] mirror: Add mirror_wait_for_io Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B22C6B.9010401@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).