From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRIYn-0003XQ-8q for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:58:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRIYm-0002vT-Fv for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:58:53 -0500 References: <1454517196-4560-1-git-send-email-mreitz@redhat.com> <1454517196-4560-3-git-send-email-mreitz@redhat.com> <56B22F6E.5090308@redhat.com> From: Paolo Bonzini Message-ID: <56B33CED.2000509@redhat.com> Date: Thu, 4 Feb 2016 12:58:37 +0100 MIME-Version: 1.0 In-Reply-To: <56B22F6E.5090308@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org, Markus Armbruster On 03/02/2016 17:48, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for >> several reasons: - Neither of InetSocketAddress nor >> UnixSocketAddress alone is sufficient, because both are >> supported - We cannot use SocketAddress because NBD does not >> support an fd, and because it is not a flat union which >> BlockdevOptionsNbd is > > Can we do it anyways, and just error out/document that fd is > unsupported? Especially because there's no reason _not_ to support fd. Sure, it's really fringe, but if qemu-socket APIs make it just work... Paolo