From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRIbt-0007oY-97 for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:02:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRIbp-0003Uw-S4 for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:02:05 -0500 References: <1454517196-4560-1-git-send-email-mreitz@redhat.com> <1454517196-4560-3-git-send-email-mreitz@redhat.com> <20160203170609.GR30222@redhat.com> <56B235F2.1050005@redhat.com> From: Paolo Bonzini Message-ID: <56B33DA8.8000900@redhat.com> Date: Thu, 4 Feb 2016 13:01:44 +0100 MIME-Version: 1.0 In-Reply-To: <56B235F2.1050005@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , "Daniel P. Berrange" Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster On 03/02/2016 18:16, Max Reitz wrote: > However, the issue remains that the NBD block driver expects > flattened options which is syntactically incompatible to > SocketAddress. Maybe the best way to address this would be to just > make block/nbd.c directly accept a SocketAddress and keep the old > flattened @host, @port, and @path options only as a legacy mapping > to inet.host, inet.port, and unix.path. Do we need to keep them at all? The URL-based file is already good enough as a shortcut for human and command-line use. Is anyone actually using host/port/path? Paolo