From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRLtF-00021M-QX for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:32:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRLtB-0001wR-MN for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:32:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRLtB-0001wA-Ef for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:32:09 -0500 References: <145459675563.11777.5257429454748921678.stgit@localhost> From: Eric Blake Message-ID: <56B36EF8.6080309@redhat.com> Date: Thu, 4 Feb 2016 08:32:08 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A2dRxwEt6xtF6TQsON3P7h7RkSViOvPpm" Subject: Re: [Qemu-devel] [PATCH ] [trivial] qapi: Build-depend on all json files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?Q?Llu=c3=ads_Vilanova?= Cc: QEMU Developers , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --A2dRxwEt6xtF6TQsON3P7h7RkSViOvPpm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/04/2016 07:55 AM, Peter Maydell wrote: > On 4 February 2016 at 14:39, Llu=C3=ADs Vilanova = wrote: >> Dynamically detects the files used to generate QAPI code, thus ensurin= g >> it's never out of sync with the sources. >> >> Signed-off-by: Llu=C3=ADs Vilanova >> --- >> Makefile | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index d0de2d4..627f772 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -269,10 +269,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scri= pts/qapi-commands.py $(qapi-py) >> $(gen-out-type) -o qga/qapi-generated -p "qga-" $<, \ >> " GEN $@") >> >> -qapi-modules =3D $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common= =2Ejson \ >> - $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-cor= e.json \ >> - $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspec= t.json \ >> - $(SRC_PATH)/qapi/crypto.json >> +qapi-modules =3D $(SRC_PATH)/qapi-schema.json >> +qapi-modules +=3D $(shell find $(SRC_PATH)/qapi -name "*.json") >=20 > All the .json files are in the same directory, so I don't think we shou= ld > need to use find here. Does >=20 > qapi-modules +=3D $(wildcard $(SRC_PATH)/qapi/*.json)) >=20 > work ? Does this wildcard affect what goes into a tarball? I'm worried that we may run the risk of a stale .json file on one developer's machine causing an unreproducible build on other machines where the file is not found; explicit lists tend to be safer than wildcards. I won't reject the patch if others like it, but I won't approve it myself= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --A2dRxwEt6xtF6TQsON3P7h7RkSViOvPpm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWs274AAoJEKeha0olJ0NqtHkIAKO1G/yT778pmXUESa3FPvIu nvzBtIemnKx5AZf0yctOXobfhxzAbsEyoPVSCOMldlvuuOAxRfBb88WlAqGFrz5Z 0ISXawTIuIASQmwXkZOttsRLMeiyrTRdmj/tS+nNuJHvrQOgSrUcvjbLGufJtxhG V4lpVgOGMR3I9nk+k2iEqF8Xhk7G8rp+PaY9vYofvyrQ/RQ0Gtid9IqSoCv7OuO5 rzfP6g47lzPrde1KN1n46BPR/+/upsjxjt9B4QTu9403VJLE1NQczbDliyUTMAqr bgc6eArtmUbTSruse+bCnGit126oURiNG8jgTlzDUyuy9s3e5bD0Y9zYO/2yj8s= =aqgy -----END PGP SIGNATURE----- --A2dRxwEt6xtF6TQsON3P7h7RkSViOvPpm--