* [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies
@ 2016-02-04 18:29 Lluís Vilanova
2016-02-04 19:28 ` Eric Blake
2016-02-05 7:40 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Lluís Vilanova @ 2016-02-04 18:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Markus Armbruster, Michael Roth
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d0de2d4..30b1b2d 100644
--- a/Makefile
+++ b/Makefile
@@ -272,7 +272,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
$(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \
$(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json \
- $(SRC_PATH)/qapi/crypto.json
+ $(SRC_PATH)/qapi/crypto.json $(SRC_PATH)/qapi/rocker.json \
+ $(SRC_PATH)/qapi/trace.json
qapi-types.c qapi-types.h :\
$(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies
2016-02-04 18:29 [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies Lluís Vilanova
@ 2016-02-04 19:28 ` Eric Blake
2016-02-05 7:40 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-02-04 19:28 UTC (permalink / raw)
To: Lluís Vilanova, qemu-devel; +Cc: Markus Armbruster, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]
On 02/04/2016 11:29 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/Makefile b/Makefile
> index d0de2d4..30b1b2d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -272,7 +272,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
> qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
> $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \
> $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json \
> - $(SRC_PATH)/qapi/crypto.json
> + $(SRC_PATH)/qapi/crypto.json $(SRC_PATH)/qapi/rocker.json \
> + $(SRC_PATH)/qapi/trace.json
>
> qapi-types.c qapi-types.h :\
> $(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
>
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies
2016-02-04 18:29 [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies Lluís Vilanova
2016-02-04 19:28 ` Eric Blake
@ 2016-02-05 7:40 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2016-02-05 7:40 UTC (permalink / raw)
To: Lluís Vilanova; +Cc: qemu-devel, Stefan Hajnoczi, Michael Roth
Lluís Vilanova <vilanova@ac.upc.edu> writes:
Suggest to add: "Forgotten in commit 1dde0f4 (trace.json) and commit
fafa4d5 (rocker.json)." Could be done on commit.
Since I have a QAPI pull request coming up, I can take it through my
tree.
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d0de2d4..30b1b2d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -272,7 +272,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
> qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
> $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \
> $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json \
> - $(SRC_PATH)/qapi/crypto.json
> + $(SRC_PATH)/qapi/crypto.json $(SRC_PATH)/qapi/rocker.json \
> + $(SRC_PATH)/qapi/trace.json
>
> qapi-types.c qapi-types.h :\
> $(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-05 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-04 18:29 [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies Lluís Vilanova
2016-02-04 19:28 ` Eric Blake
2016-02-05 7:40 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).