From: Eric Blake <eblake@redhat.com>
To: "Richard Henderson" <rth@twiddle.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com,
dgilbert@redhat.com, aurelien@aurel32.net,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v5 5/9] qemu-log: support simple pid substitution in logfile
Date: Thu, 4 Feb 2016 16:32:20 -0700 [thread overview]
Message-ID: <56B3DF84.1010109@redhat.com> (raw)
In-Reply-To: <56B3D01C.9080405@twiddle.net>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On 02/04/2016 03:26 PM, Richard Henderson wrote:
> On 02/05/2016 01:56 AM, Alex Bennée wrote:
>> + if (g_strrstr(filename, "%d")) {
>> + /* if we are going to format this we'd better validate first */
>> + if (g_regex_match_simple("^[^%]+%d[^%]+$", filename, 0, 0)) {
>
> Why g_strrstr instead of strstr? There should be only one, so why look
> for the last?
For that matter, why use a heavyweight regex, when you can achieve the
same validation with the faster:
char *tmp = strchr(filename, '%');
if (tmp) {
if (tmp[1] != 'd' || strchr(tmp + 2, '%')) {
...report invalid string
}
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-04 23:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 14:56 [Qemu-devel] [PATCH v5 0/9] qemu-log, -dfilter and other logging tweaks Alex Bennée
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 1/9] tcg: pass down TranslationBlock to tcg_code_gen Alex Bennée
2016-02-04 21:24 ` Richard Henderson
2016-02-10 15:23 ` Alex Bennée
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 2/9] qemu-log: correct help text for -d cpu Alex Bennée
2016-02-04 21:24 ` Richard Henderson
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 4/9] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2016-02-04 22:17 ` Richard Henderson
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 5/9] qemu-log: support simple pid substitution in logfile Alex Bennée
2016-02-04 22:26 ` Richard Henderson
2016-02-04 23:32 ` Eric Blake [this message]
2016-02-05 13:34 ` Alex Bennée
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output Alex Bennée
2016-02-04 23:08 ` Richard Henderson
2016-02-10 17:40 ` Alex Bennée
2016-02-10 17:58 ` Richard Henderson
2016-02-10 18:35 ` Alex Bennée
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 7/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op Alex Bennée
2016-02-04 23:09 ` Richard Henderson
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 8/9] target-arm: dfilter support for in_asm Alex Bennée
2016-02-04 14:56 ` [Qemu-devel] [PATCH v5 9/9] cputlb: modernise the debug support Alex Bennée
2016-02-04 23:10 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B3DF84.1010109@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosthwaitepeter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).