Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

[Laurent Vivier <lvivier@redhat.com>]

On 05/02/2016 11:39, Greg Kurz wrote:
> This series brings some improvements to the cross-endian support in the
> virtio and vhost code:
> - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net,
>   so that backend cross-endian capabilities benefit to both emulated and
>   vhost accelerated devices
> - optimize virtio_access_is_big_endian() for little-endian targets
> - various cleanups
> 
> This v4 is a respin of the v3, taking into account the following fix:
> 
> commit cf0a628f6e81bfc9b7a944fa0b80c3594836df56
> Author: Laurent Vivier <lvivier@redhat.com>
> Date:   Wed Jan 13 20:26:25 2016 +0100
> 
>     net: set endianness on all backend devices
> 
> It impacts patches 1 and 2, that had already been reviewed.
> 
> Laurent, Cornelia,
> 
> Could you please ack/nack the changes ?

Looks good to me.

Laurent
> 
> The series is based on Michael Tsirkin's tree:
> 
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci
> 
> Thanks.
> 
> --
> Greg
> 
> ---
> 
> Greg Kurz (6):
>       virtio-net: use the backend cross-endian capabilities
>       vhost-net: revert support of cross-endian vnet headers
>       virtio: move cross-endian helper to vhost
>       vhost: move virtio 1.0 check to cross-endian helper
>       vhost: simplify vhost_needs_vring_endian()
>       virtio: optimize virtio_access_is_big_endian() for little-endian targets
> 
> 
>  hw/net/vhost_net.c                |   41 +++-------------------
>  hw/net/virtio-net.c               |   68 ++++++++++++++++++++++++++++++++++++-
>  hw/virtio/vhost.c                 |   27 +++++++++++++--
>  include/hw/virtio/virtio-access.h |   28 ++-------------
>  include/hw/virtio/virtio-net.h    |    1 +
>  5 files changed, 98 insertions(+), 67 deletions(-)
> 
>