From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSeXw-0005nK-R5 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 00:39:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSeXv-00082k-Vt for qemu-devel@nongnu.org; Mon, 08 Feb 2016 00:39:36 -0500 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:32845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSeXv-00082b-PA for qemu-devel@nongnu.org; Mon, 08 Feb 2016 00:39:35 -0500 Received: by mail-pa0-x242.google.com with SMTP id y7so465654paa.0 for ; Sun, 07 Feb 2016 21:39:35 -0800 (PST) References: <1454638439-11938-1-git-send-email-david@gibson.dropbear.id.au> <1454638439-11938-3-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <56B82A12.6040201@ozlabs.ru> Date: Mon, 8 Feb 2016 16:39:30 +1100 MIME-Version: 1.0 In-Reply-To: <1454638439-11938-3-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] target-ppc: Include missing MMU models for SDR1 in info registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , benh@kernel.crashing.org, agraf@suse.de Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 02/05/2016 01:13 PM, David Gibson wrote: > The HMP command "info registers" produces somewhat different information on > different ppc cpu variants. For those with a hash MMU it's supposed to > include the SDR1, DAR and DSISR registers related to the MMU. However, > the switch is missing a couple of MMU model variants, meaning we will > miss out this information on certain CPUs which should have it. > > This patch corrects the oversight. (Really these MMU model IDs need a big > cleanup, but we might as well fix the bug in the interim). > > Signed-off-by: David Gibson > --- > target-ppc/translate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 0057bda..287d679 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -11352,7 +11352,9 @@ void ppc_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf, > case POWERPC_MMU_64B: > case POWERPC_MMU_2_03: > case POWERPC_MMU_2_06: > + case POWERPC_MMU_2_06a: > case POWERPC_MMU_2_07: > + case POWERPC_MMU_2_07a: > #endif > cpu_fprintf(f, " SDR1 " TARGET_FMT_lx " DAR " TARGET_FMT_lx > " DSISR " TARGET_FMT_lx "\n", env->spr[SPR_SDR1], > Reviewed-by: Alexey Kardashevskiy -- Alexey