From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSkuL-0008Q2-JV for qemu-devel@nongnu.org; Mon, 08 Feb 2016 07:27:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSkuH-0001we-GF for qemu-devel@nongnu.org; Mon, 08 Feb 2016 07:27:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSkuH-0001wa-Ap for qemu-devel@nongnu.org; Mon, 08 Feb 2016 07:27:05 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 07D36C0AA378 for ; Mon, 8 Feb 2016 12:27:05 +0000 (UTC) References: <1454931951-25212-1-git-send-email-marcel@redhat.com> <56B88890.8090000@redhat.com> From: Marcel Apfelbaum Message-ID: <56B88996.1040004@redhat.com> Date: Mon, 8 Feb 2016 14:27:02 +0200 MIME-Version: 1.0 In-Reply-To: <56B88890.8090000@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org Cc: pbonzini@redhat.com On 02/08/2016 02:22 PM, Laszlo Ersek wrote: > On 02/08/16 12:45, Marcel Apfelbaum wrote: >> Also we can use current machine properties instead of querying machine's opts. > > Why? :) For me at least, you'll have to spell it out. The theory would be that is cleaner to call an object property than use a string (when possible); compiler helps and so on... object->prop vs find_me_prop("prop") Since all machine properties have already been set with the command line options we really have no need to use them anymore and we can favor the machine. Thanks, Marcel > > Thanks > Laszlo > >> >> Signed-off-by: Marcel Apfelbaum >> --- >> vl.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index 5873248..c03a4fe 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -4353,11 +4353,10 @@ int main(int argc, char **argv, char **envp) >> qtest_init(qtest_chrdev, qtest_log, &error_fatal); >> } >> >> - machine_opts = qemu_get_machine_opts(); >> - kernel_filename = qemu_opt_get(machine_opts, "kernel"); >> - initrd_filename = qemu_opt_get(machine_opts, "initrd"); >> - kernel_cmdline = qemu_opt_get(machine_opts, "append"); >> - bios_name = qemu_opt_get(machine_opts, "firmware"); >> + kernel_filename = current_machine->kernel_filename; >> + initrd_filename = current_machine->initrd_filename; >> + kernel_cmdline = current_machine->kernel_cmdline; >> + bios_name = current_machine->firmware; >> >> opts = qemu_opts_find(qemu_find_opts("boot-opts"), NULL); >> if (opts) { >> > > Thanks > Laszlo >