From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSqvT-0006eh-O4 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 13:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSqvP-0002Zn-QF for qemu-devel@nongnu.org; Mon, 08 Feb 2016 13:52:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSqvP-0002ZT-Ju for qemu-devel@nongnu.org; Mon, 08 Feb 2016 13:52:39 -0500 References: <1454865729-5791-1-git-send-email-swarren@wwwdotorg.org> <87h9hj7etf.fsf@blackfin.pond.sub.org> From: John Snow Message-ID: <56B8E3F5.3020108@redhat.com> Date: Mon, 8 Feb 2016 13:52:37 -0500 MIME-Version: 1.0 In-Reply-To: <87h9hj7etf.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Stephen Warren Cc: Peter Maydell , qemu-devel@nongnu.org On 02/08/2016 04:05 AM, Markus Armbruster wrote: > Stephen Warren writes: > >> Add an entry to MAINTAINERS that matches every patch, and requests the >> user send patches to qemu-devel@nongnu.org. >> >> It's not 100% obvious to project newcomers that all patches should be sent >> there; checkpatch doesn't say so, and since it mentions other lists to CC, >> the wording "the list" from the SubmitAPatch wiki page can be taken >> to mean only those lists, not the main list too. >> >> The F: entries were taken from a similar entry in the Linux kernel. >> >> Signed-off-by: Stephen Warren >> --- >> MAINTAINERS | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index b6ed87a26349..2d78eea5d62d 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -52,6 +52,11 @@ General Project Administration >> ------------------------------ >> M: Peter Maydell >> >> +All patches CC here >> +L: qemu-devel@nongnu.org >> +F: * >> +F: */ >> + >> Responsible Disclosure, Reporting Security Issues >> ------------------------------ >> W: http://wiki.qemu.org/SecurityProcess > > I acknowledge the problem, but your patch breaks the "No maintainers > found, printing recent contributors" functionality. > > Before: > > $ scripts/get_maintainer.pl -f MAINTAINERS > get_maintainer.pl: No maintainers found, printing recent contributors. > get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. > > Paolo Bonzini (commit_signer:20/74=27%) > Kevin Wolf (commit_signer:13/74=18%) > Stefan Hajnoczi (commit_signer:13/74=18%) > "Michael S. Tsirkin" (commit_signer:10/74=14%) > Peter Maydell (commit_signer:8/74=11%) > > After: > > $ scripts/get_maintainer.pl -f MAINTAINERS > qemu-devel@nongnu.org (open list:All patches CC here) > Agree ... Might this also break any "unmaintained" scripts we use? How about: 1) Update the wiki to be clearer on the submission process, and 2) Update the "no contributors found" output to also include the list to send to?