From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSrut-0000P8-I7 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 14:56:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSrup-0003HA-Ch for qemu-devel@nongnu.org; Mon, 08 Feb 2016 14:56:11 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSruo-0003H3-Vl for qemu-devel@nongnu.org; Mon, 08 Feb 2016 14:56:07 -0500 Received: by mail-wm0-x22d.google.com with SMTP id g62so131886831wme.0 for ; Mon, 08 Feb 2016 11:56:06 -0800 (PST) Sender: Paolo Bonzini References: <1454865729-5791-1-git-send-email-swarren@wwwdotorg.org> <87h9hj7etf.fsf@blackfin.pond.sub.org> <56B8E3F5.3020108@redhat.com> <56B8E6A8.8080506@wwwdotorg.org> From: Paolo Bonzini Message-ID: <56B8F2D2.707@redhat.com> Date: Mon, 8 Feb 2016 20:56:02 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Stephen Warren Cc: John Snow , Markus Armbruster , QEMU Developers On 08/02/2016 20:15, Peter Maydell wrote: > That difference from the kernel script's behaviour is deliberate, because > the attempt to list recent contributors tends to list a whole lot of > irrelevant people. So if there's a documented maintainer we prefer to > just list them, and not all the random other people looking at the git > logs drags up. Commit c6561586f0f8586 is where we changed the behaviour > of get_maintainer.pl and the commit message has some rationale. It should be enough not to check @list_to in the line that commit c6561586f0f8586 adds: diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 7dacf32..f2ee9d8 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -636,7 +636,7 @@ sub get_maintainers { if ($email) { if (! $interactive) { - $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame; + $email_git_fallback = 0 if @email_to > 0 || $email_git || $email_git_blame; if ($email_git_fallback) { print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n"; print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n"; I think this makes sense. Paolo