From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSyWM-0006Hb-Lh for qemu-devel@nongnu.org; Mon, 08 Feb 2016 21:59:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSyWJ-0002WZ-FX for qemu-devel@nongnu.org; Mon, 08 Feb 2016 21:59:18 -0500 Received: from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:34972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSyWJ-0002Vz-7k for qemu-devel@nongnu.org; Mon, 08 Feb 2016 21:59:15 -0500 Received: by mail-pf0-x230.google.com with SMTP id c10so53100207pfc.2 for ; Mon, 08 Feb 2016 18:59:13 -0800 (PST) References: <1454983946-32073-1-git-send-email-david@gibson.dropbear.id.au> <1454983946-32073-6-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <56B955FA.4050405@ozlabs.ru> Date: Tue, 9 Feb 2016 13:59:06 +1100 MIME-Version: 1.0 In-Reply-To: <1454983946-32073-6-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 5/7] pseries: Move hash page table allocation to reset time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , benh@kernel.crashing.org, agraf@suse.de Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 02/09/2016 01:12 PM, David Gibson wrote: > At the moment the size of the hash page table (HPT) is fixed based on the > maximum memory allowed to the guest. As such, we allocate the table during > machine construction, and just clear it at reset. > > However, we're planning to implement a PAPR extension allowing the hash > page table to be resized at runtime. This will mean that on reset we want > to revert it to the default size. It also means that when migrating, we > need to make sure the destination allocates an HPT of size matching the > host, since the guest could have changed it before the migration. > > This patch replaces the spapr_alloc_htab() and spapr_reset_htab() functions > with a new spapr_reallocate_hpt() function. This is called at reset and > inbound migration only, not during machine init any more. > > Signed-off-by: David Gibson Patch reordering did not help much but "git difftool HEAD^^^ HEAD^^ -- hw/ppc/spapr.c" did :) Reviewed-by: Alexey Kardashevskiy -- Alexey