From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTAoZ-0005x0-74 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 11:06:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTAoV-0003lh-Ek for qemu-devel@nongnu.org; Tue, 09 Feb 2016 11:06:55 -0500 References: <1455027417-32278-1-git-send-email-pbonzini@redhat.com> <56BA0DBD.3060206@weilnetz.de> From: Paolo Bonzini Message-ID: <56BA0E97.7060002@redhat.com> Date: Tue, 9 Feb 2016 17:06:47 +0100 MIME-Version: 1.0 In-Reply-To: <56BA0DBD.3060206@weilnetz.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Peter Maydell On 09/02/2016 17:03, Stefan Weil wrote: > Reviewed-by: Stefan Weil > > Without that patch, windows.h will include winsock.h > (which conflicts with winsock2.h) when compiling sdl.c. > > Normally we define WIN32_LEAN_AND_MEAN, and > windows.h won't include winsock.h. > > include/ui/sdl2.h and ui/sdl.c undefine that macro, > so the order of the include files is important. > > Without testing this, I think that Paolo's patch is needed > since commit e16f4c8770b73f530dad842a31298963b6c7e41d. > That also explains why only that file complains. Thanks! Paolo