From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Hollis_Blanchard@mentor.com>) id 1aTC8R-00030J-35
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:31:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Hollis_Blanchard@mentor.com>) id 1aTC8M-0005Ir-15
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:31:31 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:33594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Hollis_Blanchard@mentor.com>) id 1aTC8L-0005Il-S2
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:31:25 -0500
References: <1454976185-30095-1-git-send-email-hollis_blanchard@mentor.com>
	<1454976185-30095-3-git-send-email-hollis_blanchard@mentor.com>
	<20160209155339.GB13149@stefanha-x1.localdomain>
From: Hollis Blanchard <hollis_blanchard@mentor.com>
Message-ID: <56BA226B.7050602@mentor.com>
Date: Tue, 9 Feb 2016 09:31:23 -0800
MIME-Version: 1.0
In-Reply-To: <20160209155339.GB13149@stefanha-x1.localdomain>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of
 offsets in memory tracepoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On 02/09/2016 07:53 AM, Stefan Hajnoczi wrote:
> On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote:
>> -memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
>> -memory_region_ops_write(void *mr, uint64_t offset, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
>> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
>> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> Please update the format string too ("offset" -> "addr").

Oops, thanks. Do you want me to re-send the series, or just this patch?

Hollis Blanchard
Mentor Graphics Emulation Division