From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTRul-0007lW-5G for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:22:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTRuh-0000GM-VU for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:22:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTRuh-0000GI-Pf for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:22:23 -0500 References: <20160205103927.21017.26364.stgit@bahia.huguette.org> From: Laurent Vivier Message-ID: <56BB0F5C.4070804@redhat.com> Date: Wed, 10 Feb 2016 11:22:20 +0100 MIME-Version: 1.0 In-Reply-To: <20160205103927.21017.26364.stgit@bahia.huguette.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , "Michael S. Tsirkin" Cc: Cornelia Huck , qemu-devel@nongnu.org On 05/02/2016 11:39, Greg Kurz wrote: > This series brings some improvements to the cross-endian support in the > virtio and vhost code: > - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net, > so that backend cross-endian capabilities benefit to both emulated and > vhost accelerated devices > - optimize virtio_access_is_big_endian() for little-endian targets > - various cleanups > > This v4 is a respin of the v3, taking into account the following fix: > > commit cf0a628f6e81bfc9b7a944fa0b80c3594836df56 > Author: Laurent Vivier > Date: Wed Jan 13 20:26:25 2016 +0100 > > net: set endianness on all backend devices > > It impacts patches 1 and 2, that had already been reviewed. > > Laurent, Cornelia, > > Could you please ack/nack the changes ? > > The series is based on Michael Tsirkin's tree: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci > > Thanks. > > -- > Greg > > --- > > Greg Kurz (6): > virtio-net: use the backend cross-endian capabilities > vhost-net: revert support of cross-endian vnet headers > virtio: move cross-endian helper to vhost > vhost: move virtio 1.0 check to cross-endian helper > vhost: simplify vhost_needs_vring_endian() > virtio: optimize virtio_access_is_big_endian() for little-endian targets > > > hw/net/vhost_net.c | 41 +++------------------- > hw/net/virtio-net.c | 68 ++++++++++++++++++++++++++++++++++++- > hw/virtio/vhost.c | 27 +++++++++++++-- > include/hw/virtio/virtio-access.h | 28 ++------------- > include/hw/virtio/virtio-net.h | 1 + > 5 files changed, 98 insertions(+), 67 deletions(-) > Reviewed-by: Laurent Vivier