From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTUKs-0001in-4f for qemu-devel@nongnu.org; Wed, 10 Feb 2016 07:57:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTUKo-0006ZC-Vd for qemu-devel@nongnu.org; Wed, 10 Feb 2016 07:57:34 -0500 References: <1455106941-2934-1-git-send-email-marcel@redhat.com> <1455106941-2934-2-git-send-email-marcel@redhat.com> From: Laurent Vivier Message-ID: <56BB33B6.6050402@redhat.com> Date: Wed, 10 Feb 2016 13:57:26 +0100 MIME-Version: 1.0 In-Reply-To: <1455106941-2934-2-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: jasowang@redhat.com, qemu-stable@nongnu.org, mst@redhat.com On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Commits 1811e64c and a6df8adf use the same virtio feature bit 4 > for different features. > > Fix it by using different bits. > > Reported-by: Laurent Vivier > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h > index e096e98..6686b10 100644 > --- a/hw/virtio/virtio-pci.h > +++ b/hw/virtio/virtio-pci.h > @@ -71,7 +71,7 @@ typedef struct VirtioBusClass VirtioPCIBusClass; > /* virtio version flags */ > #define VIRTIO_PCI_FLAG_DISABLE_LEGACY_BIT 2 > #define VIRTIO_PCI_FLAG_DISABLE_MODERN_BIT 3 > -#define VIRTIO_PCI_FLAG_DISABLE_PCIE_BIT 4 > +#define VIRTIO_PCI_FLAG_DISABLE_PCIE_BIT 6 > #define VIRTIO_PCI_FLAG_DISABLE_LEGACY (1 << VIRTIO_PCI_FLAG_DISABLE_LEGACY_BIT) > #define VIRTIO_PCI_FLAG_DISABLE_MODERN (1 << VIRTIO_PCI_FLAG_DISABLE_MODERN_BIT) > #define VIRTIO_PCI_FLAG_DISABLE_PCIE (1 << VIRTIO_PCI_FLAG_DISABLE_PCIE_BIT) > Reviewed-by: Laurent Vivier