* [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding
@ 2016-02-09 20:57 Dirk Müller
2016-02-10 13:34 ` Andreas Färber
2016-02-15 17:42 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Dirk Müller @ 2016-02-09 20:57 UTC (permalink / raw)
To: QEMU Developers; +Cc: Peter Maydell
See C5.1.5 of the ARMv8 Reference Manual
Signed-off-by: Dirk Mueller <dmueller@suse.com>
---
target-arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 5ea507f..954e6e8 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -3682,7 +3682,7 @@ static const ARMCPRegInfo debug_cp_reginfo[] = {
* We don't implement the configurable EL0 access.
*/
{ .name = "MDCCSR_EL0", .state = ARM_CP_STATE_BOTH,
- .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 1, .opc2 = 0,
+ .cp = 14, .opc0 = 2, .opc1 = 3, .crn = 0, .crm = 1, .opc2 = 0,
.type = ARM_CP_ALIAS,
.access = PL1_R,
.fieldoffset = offsetof(CPUARMState, cp15.mdscr_el1), },
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding
2016-02-09 20:57 [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding Dirk Müller
@ 2016-02-10 13:34 ` Andreas Färber
2016-02-15 17:42 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2016-02-10 13:34 UTC (permalink / raw)
To: Dirk Müller, QEMU Developers; +Cc: Peter Maydell
Am 09.02.2016 um 21:57 schrieb Dirk Müller:
> See C5.1.5 of the ARMv8 Reference Manual
>
> Signed-off-by: Dirk Mueller <dmueller@suse.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding
2016-02-09 20:57 [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding Dirk Müller
2016-02-10 13:34 ` Andreas Färber
@ 2016-02-15 17:42 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2016-02-15 17:42 UTC (permalink / raw)
To: Dirk Müller; +Cc: QEMU Developers
On 9 February 2016 at 20:57, Dirk Müller <dirk@dmllr.de> wrote:
> See C5.1.5 of the ARMv8 Reference Manual
>
> Signed-off-by: Dirk Mueller <dmueller@suse.com>
> ---
> target-arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 5ea507f..954e6e8 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -3682,7 +3682,7 @@ static const ARMCPRegInfo debug_cp_reginfo[] = {
> * We don't implement the configurable EL0 access.
> */
> { .name = "MDCCSR_EL0", .state = ARM_CP_STATE_BOTH,
> - .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 1, .opc2 = 0,
> + .cp = 14, .opc0 = 2, .opc1 = 3, .crn = 0, .crm = 1, .opc2 = 0,
> .type = ARM_CP_ALIAS,
> .access = PL1_R,
> .fieldoffset = offsetof(CPUARMState, cp15.mdscr_el1), },
Hi; you're right that we have the wrong encoding for the AArch64
register here, but this change would break the AArch32 version
(which is at cp14, 0, c0, c1, 0). You need to split the regdef
into two, one for AArch64 and one for AArch32.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-15 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 20:57 [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding Dirk Müller
2016-02-10 13:34 ` Andreas Färber
2016-02-15 17:42 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).