From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe
Date: Wed, 10 Feb 2016 16:29:44 +0100 [thread overview]
Message-ID: <56BB5768.7040006@redhat.com> (raw)
In-Reply-To: <56BB4F59.7090606@redhat.com>
On 10/02/2016 15:55, Laszlo Ersek wrote:
>> > Hmm, not sure why. We're comparing against the inclusive-exclusive
>> > range [0,s->vga.vram_size). The right way to check if something is
>> > within the range is >= min && < max; the right way to check if something
>> > is outside the range is < min || >= max.
> Absolutely: if the thing you are verifying against the interval is
> itself an inclusive thing, that is, a pixel or byte *drawn*. However,
> exactly as you stated in the commit message, for the maximum check, what
> we are comparing is the first offset *not* processed.
Right, what my patch does is setting min and max both to pixels that are
drawn.
Paolo
next prev parent reply other threads:[~2016-02-10 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 10:59 [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe Paolo Bonzini
2016-02-09 19:08 ` Laszlo Ersek
2016-02-10 12:32 ` Paolo Bonzini
2016-02-10 14:55 ` Laszlo Ersek
2016-02-10 15:29 ` Paolo Bonzini [this message]
2016-02-10 15:54 ` Laszlo Ersek
2016-02-10 16:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB5768.7040006@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).