From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXYn-0006Gq-RS for qemu-devel@nongnu.org; Wed, 10 Feb 2016 11:24:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTXYi-00010p-Sh for qemu-devel@nongnu.org; Wed, 10 Feb 2016 11:24:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXYi-00010i-Mh for qemu-devel@nongnu.org; Wed, 10 Feb 2016 11:24:04 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 4460C19F98E for ; Wed, 10 Feb 2016 16:24:04 +0000 (UTC) References: <1455119605-31261-1-git-send-email-lprosek@redhat.com> <1455119605-31261-5-git-send-email-lprosek@redhat.com> From: Paolo Bonzini Message-ID: <56BB641F.3020104@redhat.com> Date: Wed, 10 Feb 2016 17:23:59 +0100 MIME-Version: 1.0 In-Reply-To: <1455119605-31261-5-git-send-email-lprosek@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, pagupta@redhat.com On 10/02/2016 16:53, Ladi Prosek wrote: > + req->size = size; > + req->receive_entropy = receive_entropy; > + req->opaque = opaque; > + req->data = g_malloc(req->size); > + > + k->request_entropy(s, req); > + > + s->requests = g_slist_append(s->requests, req); > } g_slist_append has to traverse the entire list to find the place to add the node. You probably are better off using QSIMPLEQ (which is an intrusive list unlike GSList). Thanks, Paolo