From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit
Date: Wed, 10 Feb 2016 18:44:06 +0100 [thread overview]
Message-ID: <56BB76E6.10901@redhat.com> (raw)
In-Reply-To: <1455113505-11237-1-git-send-email-pbonzini@redhat.com>
On 10.02.2016 15:11, Paolo Bonzini wrote:
> The last two arguments to these functions are the last and first bit to
> check relative to the base. The code was using incorrectly the first
> bit and the number of bits. Fix this in cpu_physical_memory_get_dirty
> and cpu_physical_memory_all_dirty. This requires a few changes in the
> iteration; change the code in cpu_physical_memory_set_dirty_range to
> match.
>
> Fixes: 5b82b70
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
That commit 5b82b70 also broke the pseries machine on qemu-ppc64:
--------------------------------- 8< --------------------------------------
$ ppc64-softmmu/qemu-system-ppc64 -net none -nographic -vga none
SLOF **********************************************************************
QEMU Starting
Build Date = Nov 5 2015 15:23:31
FW Version = git-b4c93802a5b2c72f
Press "s" to enter Open Firmware.
SLOF **********************************************************************
QEMU Starting
Build Date = Nov 5 2015 15:23:31
FW Version = git-b4c93802a5b2c72f
ERROR: Flatten device tree not available!
Press "s" to enter Open Firmware.
!!! roomfs lookup(bootinfo) = 1
Cannot find romfs file xvect
!!! roomfs lookup(bootinfo) = 1
ERROR: Not enough memory for Open Firmware
qemu: fatal: Trying to execute code outside RAM or ROM at 0xffffffffffbf0000
--------------------------------- 8< --------------------------------------
With your patch here applied, SLOF boots fine again, so:
Tested-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-02-10 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 14:11 [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit Paolo Bonzini
2016-02-10 14:23 ` Stefan Hajnoczi
2016-02-10 17:29 ` Leon Alrae
2016-02-10 17:44 ` Thomas Huth [this message]
2016-02-10 22:40 ` Peter Maydell
2016-02-11 9:46 ` Paolo Bonzini
2016-02-11 10:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB76E6.10901@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).