From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTYoJ-0003Up-DN for qemu-devel@nongnu.org; Wed, 10 Feb 2016 12:44:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTYoE-0005fu-BT for qemu-devel@nongnu.org; Wed, 10 Feb 2016 12:44:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTYoE-0005fp-62 for qemu-devel@nongnu.org; Wed, 10 Feb 2016 12:44:10 -0500 References: <1455113505-11237-1-git-send-email-pbonzini@redhat.com> From: Thomas Huth Message-ID: <56BB76E6.10901@redhat.com> Date: Wed, 10 Feb 2016 18:44:06 +0100 MIME-Version: 1.0 In-Reply-To: <1455113505-11237-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, stefanha@redhat.com On 10.02.2016 15:11, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and cpu_physical_memory_all_dirty. This requires a few changes in the > iteration; change the code in cpu_physical_memory_set_dirty_range to > match. > > Fixes: 5b82b70 > Cc: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini That commit 5b82b70 also broke the pseries machine on qemu-ppc64: --------------------------------- 8< -------------------------------------- $ ppc64-softmmu/qemu-system-ppc64 -net none -nographic -vga none SLOF ********************************************************************** QEMU Starting Build Date = Nov 5 2015 15:23:31 FW Version = git-b4c93802a5b2c72f Press "s" to enter Open Firmware. SLOF ********************************************************************** QEMU Starting Build Date = Nov 5 2015 15:23:31 FW Version = git-b4c93802a5b2c72f ERROR: Flatten device tree not available! Press "s" to enter Open Firmware. !!! roomfs lookup(bootinfo) = 1 Cannot find romfs file xvect !!! roomfs lookup(bootinfo) = 1 ERROR: Not enough memory for Open Firmware qemu: fatal: Trying to execute code outside RAM or ROM at 0xffffffffffbf0000 --------------------------------- 8< -------------------------------------- With your patch here applied, SLOF boots fine again, so: Tested-by: Thomas Huth