From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit
Date: Thu, 11 Feb 2016 10:46:04 +0100 [thread overview]
Message-ID: <56BC585C.7010604@redhat.com> (raw)
In-Reply-To: <CAFEAcA9GG7C=pLGMKBRssEONRw7g=9BtygPJ6kgJ8isfi=XzOg@mail.gmail.com>
On 10/02/2016 23:40, Peter Maydell wrote:
> On 10 February 2016 at 14:11, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> The last two arguments to these functions are the last and first bit to
>> check relative to the base. The code was using incorrectly the first
>> bit and the number of bits. Fix this in cpu_physical_memory_get_dirty
>> and cpu_physical_memory_all_dirty. This requires a few changes in the
>> iteration; change the code in cpu_physical_memory_set_dirty_range to
>> match.
>>
>> Fixes: 5b82b70
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> I've set the pre-merge tests running so I should be able
> to commit this to master first thing tomorrow. Was this
> the only patch that needs applying to fix your pullreq?
Nothing else.
Paolo
next prev parent reply other threads:[~2016-02-11 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 14:11 [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit Paolo Bonzini
2016-02-10 14:23 ` Stefan Hajnoczi
2016-02-10 17:29 ` Leon Alrae
2016-02-10 17:44 ` Thomas Huth
2016-02-10 22:40 ` Peter Maydell
2016-02-11 9:46 ` Paolo Bonzini [this message]
2016-02-11 10:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC585C.7010604@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).