From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTnpF-0002If-9u for qemu-devel@nongnu.org; Thu, 11 Feb 2016 04:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTnpB-0005Ku-9I for qemu-devel@nongnu.org; Thu, 11 Feb 2016 04:46:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTnpB-0005Km-3u for qemu-devel@nongnu.org; Thu, 11 Feb 2016 04:46:09 -0500 References: <1455113505-11237-1-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <56BC585C.7010604@redhat.com> Date: Thu, 11 Feb 2016 10:46:04 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Stefan Hajnoczi On 10/02/2016 23:40, Peter Maydell wrote: > On 10 February 2016 at 14:11, Paolo Bonzini wrote: >> The last two arguments to these functions are the last and first bit to >> check relative to the base. The code was using incorrectly the first >> bit and the number of bits. Fix this in cpu_physical_memory_get_dirty >> and cpu_physical_memory_all_dirty. This requires a few changes in the >> iteration; change the code in cpu_physical_memory_set_dirty_range to >> match. >> >> Fixes: 5b82b70 >> Cc: Stefan Hajnoczi >> Signed-off-by: Paolo Bonzini > > I've set the pre-merge tests running so I should be able > to commit this to master first thing tomorrow. Was this > the only patch that needs applying to fix your pullreq? Nothing else. Paolo