qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Amit Shah <amit.shah@redhat.com>,
	"Jason Wang (jasowang@redhat.com)" <jasowang@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
	qemu list <qemu-devel@nongnu.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000
Date: Thu, 11 Feb 2016 14:04:06 +0100	[thread overview]
Message-ID: <56BC86C6.6060103@redhat.com> (raw)
In-Reply-To: <1483e0d74dcfd183ff46dd63cc57e1fe8b775bf8.1454680535.git.amit.shah@redhat.com>



On 05/02/2016 14:56, Amit Shah wrote:
> Commit 8304402033e8dbe8e379017d51ed1dd8344f1dce changed the name of the
> e1000-82540em device to e1000.  This was flagged:
> 
>    Section "e1000-82540em" does not exist in dest
> 
> Add the mapping to the changed section names dictionary so the checker
> can proceed.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Message-Id: <7ccfe834c897142dceaa4da87c13b7059fa12aa8.1450416947.git.amit.shah@redhat.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  scripts/vmstate-static-checker.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/vmstate-static-checker.py b/scripts/vmstate-static-checker.py
> index b6c0bbe..b5ecaf6 100755
> --- a/scripts/vmstate-static-checker.py
> +++ b/scripts/vmstate-static-checker.py
> @@ -99,6 +99,7 @@ def get_changed_sec_name(sec):
>      # Section names can change -- see commit 292b1634 for an example.
>      changes = {
>          "ICH9 LPC": "ICH9-LPC",
> +        "e1000-82540em": "e1000",
>      }
>  
>      for item in changes:
> 

This means that 2.5 cannot migrate 2.4 virtual machines, right?  Is that
something we want to rectify in 2.6 by making e1000-82540em an alias of
e1000 (instead of the other way round)?

Paolo

  reply	other threads:[~2016-02-11 13:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 13:56 [Qemu-devel] [PULL 0/9] migration: small fixes Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 1/9] ram: Split host_from_stream_offset() into two helper functions Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 2/9] migration: rename 'file' in MigrationState to 'to_dst_file' Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 3/9] savevm: Split load vm state function qemu_loadvm_state Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 4/9] migration/ram: Fix some helper functions' parameter to use PageSearchStatus Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 5/9] qmp-commands.hx: Fix the missing options for migration parameters commands Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 6/9] qmp-commands.hx: Document the missing options for migration capability commands Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 7/9] migration: remove useless code Amit Shah
2016-02-05 13:56 ` [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000 Amit Shah
2016-02-11 13:04   ` Paolo Bonzini [this message]
2016-02-22 12:39     ` Amit Shah
2016-02-23  7:02       ` Jason Wang
2016-02-23  7:41         ` Amit Shah
2016-04-05 13:32           ` Dr. David Alan Gilbert
2016-04-06  1:48             ` Jason Wang
2016-04-06 13:52               ` Amit Shah
2016-04-07  7:25                 ` Jason Wang
2016-02-05 13:56 ` [Qemu-devel] [PULL 9/9] migration: fix bad string passed to error_report() Amit Shah
2016-02-05 15:06 ` [Qemu-devel] [PULL 0/9] migration: small fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BC86C6.6060103@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).