From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTquq-0000UW-Pm for qemu-devel@nongnu.org; Thu, 11 Feb 2016 08:04:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTqun-00018J-JX for qemu-devel@nongnu.org; Thu, 11 Feb 2016 08:04:12 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:35018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTqun-00018F-C5 for qemu-devel@nongnu.org; Thu, 11 Feb 2016 08:04:09 -0500 Received: by mail-wm0-x230.google.com with SMTP id c200so72196597wme.0 for ; Thu, 11 Feb 2016 05:04:09 -0800 (PST) Sender: Paolo Bonzini References: <1483e0d74dcfd183ff46dd63cc57e1fe8b775bf8.1454680535.git.amit.shah@redhat.com> From: Paolo Bonzini Message-ID: <56BC86C6.6060103@redhat.com> Date: Thu, 11 Feb 2016 14:04:06 +0100 MIME-Version: 1.0 In-Reply-To: <1483e0d74dcfd183ff46dd63cc57e1fe8b775bf8.1454680535.git.amit.shah@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , "Jason Wang (jasowang@redhat.com)" Cc: Juan Quintela , qemu list , "Dr. David Alan Gilbert" On 05/02/2016 14:56, Amit Shah wrote: > Commit 8304402033e8dbe8e379017d51ed1dd8344f1dce changed the name of the > e1000-82540em device to e1000. This was flagged: > > Section "e1000-82540em" does not exist in dest > > Add the mapping to the changed section names dictionary so the checker > can proceed. > > Signed-off-by: Amit Shah > Acked-by: Jason Wang > Message-Id: <7ccfe834c897142dceaa4da87c13b7059fa12aa8.1450416947.git.amit.shah@redhat.com> > Signed-off-by: Amit Shah > --- > scripts/vmstate-static-checker.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/vmstate-static-checker.py b/scripts/vmstate-static-checker.py > index b6c0bbe..b5ecaf6 100755 > --- a/scripts/vmstate-static-checker.py > +++ b/scripts/vmstate-static-checker.py > @@ -99,6 +99,7 @@ def get_changed_sec_name(sec): > # Section names can change -- see commit 292b1634 for an example. > changes = { > "ICH9 LPC": "ICH9-LPC", > + "e1000-82540em": "e1000", > } > > for item in changes: > This means that 2.5 cannot migrate 2.4 virtual machines, right? Is that something we want to rectify in 2.6 by making e1000-82540em an alias of e1000 (instead of the other way round)? Paolo