From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUFxz-0001eX-6l for qemu-devel@nongnu.org; Fri, 12 Feb 2016 10:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUFxx-0005wx-Vh for qemu-devel@nongnu.org; Fri, 12 Feb 2016 10:49:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUFxx-0005wg-Px for qemu-devel@nongnu.org; Fri, 12 Feb 2016 10:49:05 -0500 References: <1455043788-28112-1-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <56BDFEF0.9080002@redhat.com> Date: Fri, 12 Feb 2016 08:49:04 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k4ctcqrLWLJjk0A1slfJVe2xrPwGMTG0A" Subject: Re: [Qemu-devel] [PATCH] build: Don't redefine 'inline' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --k4ctcqrLWLJjk0A1slfJVe2xrPwGMTG0A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/12/2016 06:24 AM, Peter Maydell wrote: > On 9 February 2016 at 18:49, Eric Blake wrote: >> Actively redefining 'inline' is wrong for C++, where gcc has an >> extension 'inline namespace' which fails to compile if the >> keyword 'inline' is replaced by a macro expansion. This will >> matter once we start to include "qemu/osdep.h" first from C++ >> files, depending also on whether the system headers are new >> enough to be using the gcc extension. >> >> But rather than just guard things by __cplusplus, let's look at >> the overall picture. Commit df2542c737ea2 in 2007 defined 'inline' >> to the gcc attribute __always_inline__, with the rationale "To >> avoid discarded inlining bug". But compilers have improved since >> then, and we are probably better off trusting the compiler rather >> than trying to force its hand. >> >> So just nuke our craziness. >> >> Signed-off-by: Eric Blake >=20 > Reviewed-by: Peter Maydell >=20 > (and tested that it passes my usual merge build tests). >=20 > Does this patch suffice to get your system to build all > my clean-includes patches? Yes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --k4ctcqrLWLJjk0A1slfJVe2xrPwGMTG0A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWvf7wAAoJEKeha0olJ0NqQ6sH/2COeQ/EEyafVm/iIr8ylQvy rMexT7wQ7MBS25CB0mP/buDlgJrDjCZ5lhx38k+6+oBVXCdFn5u97zLopW0qqIBy y5S7uILcftRGODOSCIGs8KllZYY1BHgh3FIfUSiye9Zal6XkjrezTYjrZ8NdzYQh YE88+yAZj5d2Fnp9HyQrM4nHtBo1Wuk1gPV6wg7bk633pamtk01/fz3KvPZmm1NJ QZUPfsHQM5gsJE5iKpDd0sTx+GsfFoxvIWfE8bclWOTMrrzhBqCjCx3wm6eVo04B O1HwLFNIArv+7qSuvuR5+Z9VSFeBomvXg/K7iUi5hNeZjYBRoKKW0NxDXcOeWGo= =AEzi -----END PGP SIGNATURE----- --k4ctcqrLWLJjk0A1slfJVe2xrPwGMTG0A--