From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1aUJUP-0002MG-JP
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 14:34:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1aUJUK-0000jr-Ew
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 14:34:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47412)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1aUJUK-0000jL-8v
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 14:34:44 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 5007492476
	for <qemu-devel@nongnu.org>; Fri, 12 Feb 2016 19:34:43 +0000 (UTC)
References: <1455303747-19776-1-git-send-email-ehabkost@redhat.com>
	<1455303747-19776-3-git-send-email-ehabkost@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <56BE33D0.6020201@redhat.com>
Date: Fri, 12 Feb 2016 21:34:40 +0200
MIME-Version: 1.0
In-Reply-To: <1455303747-19776-3-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/4] vl: Reset location after handling
 command-line arguments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, lersek@redhat.com, armbru@redhat.com

On 02/12/2016 09:02 PM, Eduardo Habkost wrote:
> After looping through all command-line arguments, error location
> info becomes obsolete, and any function calling error_report()
> will print misleading information. This breaks error reporting
> for some option handling, like:
>
>    $ qemu-system-x86_64 -icount rr=x -vnc :0
>    qemu-system-x86_64: -vnc :0: Invalid icount rr option: x
>
>    $ qemu-system-x86_64 -m size= -vnc :0
>    qemu-system-x86_64: -vnc :0: missing 'size' option value
>
> Fix this by resetting location info as soon as we exit the
> command-line handling loop.
>
> With this, replay_configure() and set_memory_options() won't
> print any location info yet, but at least they won't print
> incorrect information.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   vl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index afbf13f..50cd018 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4053,14 +4053,14 @@ int main(int argc, char **argv, char **envp)
>           }
>       }
>
> +    loc_set_none();
> +
>       replay_configure(icount_opts);
>
>       set_machine_options(&machine_class);
>
>       set_memory_options(&ram_slots, &maxram_size, machine_class);
>
> -    loc_set_none();
> -
>       os_daemonize();
>
>       if (qemu_init_main_loop(&main_loop_err)) {
>


Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>


Thanks,
Marcel