From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUJUw-0003Az-SB for qemu-devel@nongnu.org; Fri, 12 Feb 2016 14:35:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUJUv-0001Ay-PP for qemu-devel@nongnu.org; Fri, 12 Feb 2016 14:35:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUJUv-0001AV-Io for qemu-devel@nongnu.org; Fri, 12 Feb 2016 14:35:21 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 3C7EA8EA3B for ; Fri, 12 Feb 2016 19:35:21 +0000 (UTC) References: <1455303747-19776-1-git-send-email-ehabkost@redhat.com> <1455303747-19776-5-git-send-email-ehabkost@redhat.com> From: Marcel Apfelbaum Message-ID: <56BE33F6.9050901@redhat.com> Date: Fri, 12 Feb 2016 21:35:18 +0200 MIME-Version: 1.0 In-Reply-To: <1455303747-19776-5-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] vl: Set error location when parsing memory options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Paolo Bonzini , lersek@redhat.com, armbru@redhat.com On 02/12/2016 09:02 PM, Eduardo Habkost wrote: > Set error location so the error_report() calls will show > appropriate command-line argument or config file info. > > Signed-off-by: Eduardo Habkost > --- > vl.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/vl.c b/vl.c > index 50cd018..8fe79dd 100644 > --- a/vl.c > +++ b/vl.c > @@ -2907,6 +2907,10 @@ static void set_memory_options(uint64_t *ram_slots, ram_addr_t *maxram_size, > const char *maxmem_str, *slots_str; > const ram_addr_t default_ram_size = mc->default_ram_size; > QemuOpts *opts = qemu_find_opts_singleton("memory"); > + Location loc; > + > + loc_push_none(&loc); > + qemu_opts_loc_restore(opts); > > sz = 0; > mem_str = qemu_opt_get(opts, "size"); > @@ -2981,6 +2985,8 @@ static void set_memory_options(uint64_t *ram_slots, ram_addr_t *maxram_size, > "'%s' option", slots_str ? "maxmem" : "slots"); > exit(EXIT_FAILURE); > } > + > + loc_pop(&loc); > } > > int main(int argc, char **argv, char **envp) > Reviewed-by: Marcel Apfelbaum Thanks, Marcel