From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUpU1-0002Qe-NI for qemu-devel@nongnu.org; Sun, 14 Feb 2016 00:44:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUpTx-0004dv-MI for qemu-devel@nongnu.org; Sun, 14 Feb 2016 00:44:33 -0500 Received: from mga09.intel.com ([134.134.136.24]:29724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUpTx-0004dp-GS for qemu-devel@nongnu.org; Sun, 14 Feb 2016 00:44:29 -0500 References: <1452624610-46945-1-git-send-email-guangrong.xiao@linux.intel.com> <1452624610-46945-3-git-send-email-guangrong.xiao@linux.intel.com> <20160204181721-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <56C01260.1080708@linux.intel.com> Date: Sun, 14 Feb 2016 13:36:32 +0800 MIME-Version: 1.0 In-Reply-To: <20160204181721-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 02/11] tests: acpi: test NVDIMM tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 02/05/2016 12:20 AM, Michael S. Tsirkin wrote: > On Wed, Jan 13, 2016 at 02:50:01AM +0800, Xiao Guangrong wrote: >> Add nvdimm test, two tables are created which are NFIT and >> SSDT >> >> Max memory size and multiple slots are needed to enable NVDIMM which >> cause the primal SSDT table is also updated >> >> Signed-off-by: Xiao Guangrong > > First don't include binary in patches directly please. Okay. > >> --- >> tests/acpi-test-data/pc/NFIT | Bin 0 -> 224 bytes >> tests/acpi-test-data/pc/NFIT.bridge | Bin 0 -> 224 bytes >> tests/acpi-test-data/pc/SSDT | Bin 2486 -> 2885 bytes >> tests/acpi-test-data/pc/SSDT-NVDIMM | Bin 0 -> 134 bytes >> tests/acpi-test-data/pc/SSDT-NVDIMM.bridge | Bin 0 -> 134 bytes >> tests/acpi-test-data/pc/SSDT.bridge | Bin 4345 -> 4745 bytes >> tests/acpi-test-data/q35/NFIT | Bin 0 -> 224 bytes >> tests/acpi-test-data/q35/NFIT.bridge | Bin 0 -> 224 bytes >> tests/acpi-test-data/q35/SSDT | Bin 691 -> 1090 bytes >> tests/acpi-test-data/q35/SSDT-NVDIMM | Bin 0 -> 134 bytes >> tests/acpi-test-data/q35/SSDT-NVDIMM.bridge | Bin 0 -> 134 bytes >> tests/acpi-test-data/q35/SSDT.bridge | Bin 708 -> 1107 bytes >> tests/bios-tables-test.c | 15 ++++++++++----- > > So let's add an new test, and there only test the NVDIMM tables and only > with one configuration. > > Otherwise number of tables to maintain explodes. > > You will have to teach test to ignore everything > that does not have NVDIMM in name for this test. > Okay, i will it as the single test and make it as a separate patchset.