From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1aUwNV-0004u7-1j
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 08:06:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1aUwNR-00089J-TS
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 08:06:16 -0500
Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:38689)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1aUwNR-000894-Mk
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 08:06:13 -0500
Received: by mail-wm0-x230.google.com with SMTP id a4so23525452wme.1
	for <qemu-devel@nongnu.org>; Sun, 14 Feb 2016 05:06:13 -0800 (PST)
References: <1453130745-25793-1-git-send-email-davidkiarie4@gmail.com>
	<1453130745-25793-3-git-send-email-davidkiarie4@gmail.com>
	<569D1120.7020202@redhat.com>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-ID: <56C07BC3.30208@gmail.com>
Date: Sun, 14 Feb 2016 15:06:11 +0200
MIME-Version: 1.0
In-Reply-To: <569D1120.7020202@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V4 2/4] hw/core: Add AMD IO MMU to machine
 properties
Reply-To: marcel@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>, David Kiarie <davidkiarie4@gmail.com>, qemu-devel@nongnu.org
Cc: valentine.sinitsyn@gmail.com, jan.kiszka@web.de, crosthwaitepeter@gmail.com, mst@redhat.com

On 01/18/2016 06:21 PM, Marcel Apfelbaum wrote:
> On 01/18/2016 05:25 PM, David Kiarie wrote:
>> Add IO MMU as a string to machine properties which
>> is used to control whether and the type of IO MMU
>> to emulate
>>
>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>> ---
[...]
> Hi,
>
> I am sorry for bugging you, please don't re-post before
> you get more meaningful reviews,

I meant "meaningful reviews" *from others*, not from me :)
If you have the time, please do re-post.

Anyway, I will give it a try and read the AMD IOMMU spec, maybe I can help
with patch [1/4] review.

Thanks,
Marcel

[...]