From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVYdH-0000s9-QM for qemu-devel@nongnu.org; Tue, 16 Feb 2016 00:57:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVYdG-0000Eo-SX for qemu-devel@nongnu.org; Tue, 16 Feb 2016 00:57:07 -0500 Received: from mx2.parallels.com ([199.115.105.18]:37207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVYdG-0000EM-MY for qemu-devel@nongnu.org; Tue, 16 Feb 2016 00:57:06 -0500 References: <1455259174-3384-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <56C2BA28.7020105@openvz.org> Date: Tue, 16 Feb 2016 08:56:56 +0300 MIME-Version: 1.0 In-Reply-To: <1455259174-3384-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Shah , Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela On 02/12/2016 09:39 AM, Denis V. Lunev wrote: > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The problem is that qcow2_invalidate_cache() closes the image and > memset()s BDRVQcowState in the middle. > > This operation should not be performed in coroutine context. > > Changes from v1: > - fixed spelling. Eric, thank you for spell checking > > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Juan Quintela > CC: Amit Shah > ping