From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVbRY-00011d-Tl for qemu-devel@nongnu.org; Tue, 16 Feb 2016 03:57:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVbRT-0008Qp-UY for qemu-devel@nongnu.org; Tue, 16 Feb 2016 03:57:12 -0500 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:55567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVbRT-0008Qi-Kd for qemu-devel@nongnu.org; Tue, 16 Feb 2016 03:57:07 -0500 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Feb 2016 08:57:05 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4E15817D8042 for ; Tue, 16 Feb 2016 08:57:21 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1G8v3uV37158952 for ; Tue, 16 Feb 2016 08:57:03 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1G8v320026045 for ; Tue, 16 Feb 2016 01:57:03 -0700 References: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> From: Christian Borntraeger Message-ID: <56C2E45F.2080103@de.ibm.com> Date: Tue, 16 Feb 2016 09:57:03 +0100 MIME-Version: 1.0 In-Reply-To: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] virtio: allow migration with dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: stefanha@redhat.com, mst@redhat.com On 02/14/2016 06:17 PM, Paolo Bonzini wrote: > Currently, dataplane threads are shut down during migration because > vring.c is not able to track dirty memory. However, all the relevant > parts of QEMU have been made thread-safe now, so we can drop vring.c > completely. With these patches, virtio-dataplane is now simply "virtio > with ioeventfd in a different AioContext". Can you provide a branch somewhere? Then I can at least test even if I have no time review. > > Paolo Bonzini (8): > block-migration: acquire AioContext as necessary > vring: make vring_enable_notification return void > virtio: add AioContext-specific function for host notifiers > virtio: export vring_notify as virtio_should_notify > virtio-blk: fix "disabled data plane" mode > virtio-blk: do not use vring in dataplane > virtio-scsi: do not use vring in dataplane > vring: remove > > hw/block/dataplane/virtio-blk.c | 130 +----- > hw/block/dataplane/virtio-blk.h | 1 + > hw/block/virtio-blk.c | 51 +-- > hw/scsi/virtio-scsi-dataplane.c | 196 ++------- > hw/scsi/virtio-scsi.c | 52 +-- > hw/virtio/Makefile.objs | 1 - > hw/virtio/dataplane/Makefile.objs | 1 - > hw/virtio/dataplane/vring.c | 549 -------------------------- > hw/virtio/virtio.c | 20 +- > include/hw/virtio/dataplane/vring-accessors.h | 75 ---- > include/hw/virtio/dataplane/vring.h | 51 --- > include/hw/virtio/virtio-blk.h | 4 +- > include/hw/virtio/virtio-scsi.h | 21 +- > include/hw/virtio/virtio.h | 3 + > migration/block.c | 61 ++- > trace-events | 3 - > 16 files changed, 134 insertions(+), 1085 deletions(-) > delete mode 100644 hw/virtio/dataplane/Makefile.objs > delete mode 100644 hw/virtio/dataplane/vring.c > delete mode 100644 include/hw/virtio/dataplane/vring-accessors.h > delete mode 100644 include/hw/virtio/dataplane/vring.h >