From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVcJK-00030K-HG for qemu-devel@nongnu.org; Tue, 16 Feb 2016 04:52:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVcJF-0005L7-Uk for qemu-devel@nongnu.org; Tue, 16 Feb 2016 04:52:46 -0500 Received: from m12-18.163.com ([220.181.12.18]:40734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVcJE-0005Kr-QY for qemu-devel@nongnu.org; Tue, 16 Feb 2016 04:52:41 -0500 References: <1453863283-7562-1-git-send-email-zxq_yx_007@163.com> <1453863283-7562-10-git-send-email-zxq_yx_007@163.com> <56C2ED40.2000806@163.com> From: hitmoon Message-ID: <56C2F111.40108@163.com> Date: Tue, 16 Feb 2016 17:51:13 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , =?UTF-8?Q?Andreas_F=c3=a4rber?= 在 2016年02月16日 17:41, Peter Maydell 写道: > On 16 February 2016 at 09:34, hitmoon wrote: >> >> 在 2016年02月16日 02:14, Peter Maydell 写道: >>> On 27 January 2016 at 02:54, xiaoqiang zhao wrote: >>>>> * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init >>>>> and milkymist_sysctl_realize >>> I think the "info" in this function name is wrong ? >>> >> I can not understand , can you give me more details? > The two functions which you have split the old > milkymist_sysctl_init() into are named "milkymist_sysctl_init()" > and "milkymist_sysctl_realize()". It confused me that you > said "split FUNCTION into STRUCT.FIELDNAME and FUNCTION"; > I expected to read "split FUNCTION into FUNCTION and FUNCTION". > > If you want you could just say > "Split the old SysBus init function into an instance_init > and a Device realize function." > (at the moment your two bullet points in the commit message > are actually both describing the same thing.) > > thanks > -- PMM I see ;-)