* [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4
@ 2016-02-16 2:20 David Gibson
2016-02-16 4:26 ` Laszlo Ersek
2016-02-16 11:11 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: David Gibson @ 2016-02-16 2:20 UTC (permalink / raw)
To: agraf, aik; +Cc: cornelia.huck, qemu-ppc, lersek, qemu-devel, David Gibson
Commit 4b23699 "pseries: Add pseries-2.6 machine type" added a new
SPAPR_COMPAT_2_5 macro in the usual way. However, it didn't add this
macro to the existing SPAPR_COMPAT_2_4 macro so that pseries-2.4
inherits newer compatibility properties which are needed for 2.5 and
earlier.
This corrects the oversight.
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 276d6b4..e214a34 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2391,6 +2391,7 @@ DEFINE_SPAPR_MACHINE(2_5, "2.5", false);
* pseries-2.4
*/
#define SPAPR_COMPAT_2_4 \
+ SPAPR_COMPAT_2_5 \
HW_COMPAT_2_4
static void spapr_machine_2_4_instance_options(MachineState *machine)
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4
2016-02-16 2:20 [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4 David Gibson
@ 2016-02-16 4:26 ` Laszlo Ersek
2016-02-16 11:11 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2016-02-16 4:26 UTC (permalink / raw)
To: David Gibson, agraf, aik; +Cc: cornelia.huck, qemu-ppc, qemu-devel
On 02/16/16 03:20, David Gibson wrote:
> Commit 4b23699 "pseries: Add pseries-2.6 machine type" added a new
> SPAPR_COMPAT_2_5 macro in the usual way. However, it didn't add this
> macro to the existing SPAPR_COMPAT_2_4 macro so that pseries-2.4
> inherits newer compatibility properties which are needed for 2.5 and
> earlier.
>
> This corrects the oversight.
>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 276d6b4..e214a34 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2391,6 +2391,7 @@ DEFINE_SPAPR_MACHINE(2_5, "2.5", false);
> * pseries-2.4
> */
> #define SPAPR_COMPAT_2_4 \
> + SPAPR_COMPAT_2_5 \
> HW_COMPAT_2_4
>
> static void spapr_machine_2_4_instance_options(MachineState *machine)
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4
2016-02-16 2:20 [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4 David Gibson
2016-02-16 4:26 ` Laszlo Ersek
@ 2016-02-16 11:11 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2016-02-16 11:11 UTC (permalink / raw)
To: David Gibson, agraf, aik; +Cc: cornelia.huck, lersek, qemu-ppc, qemu-devel
On 16/02/2016 03:20, David Gibson wrote:
> Commit 4b23699 "pseries: Add pseries-2.6 machine type" added a new
> SPAPR_COMPAT_2_5 macro in the usual way. However, it didn't add this
> macro to the existing SPAPR_COMPAT_2_4 macro so that pseries-2.4
> inherits newer compatibility properties which are needed for 2.5 and
> earlier.
>
> This corrects the oversight.
>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 276d6b4..e214a34 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2391,6 +2391,7 @@ DEFINE_SPAPR_MACHINE(2_5, "2.5", false);
> * pseries-2.4
> */
> #define SPAPR_COMPAT_2_4 \
> + SPAPR_COMPAT_2_5 \
> HW_COMPAT_2_4
>
> static void spapr_machine_2_4_instance_options(MachineState *machine)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-16 11:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 2:20 [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4 David Gibson
2016-02-16 4:26 ` Laszlo Ersek
2016-02-16 11:11 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).