From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aViVr-0003PV-3O for qemu-devel@nongnu.org; Tue, 16 Feb 2016 11:30:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aViVl-0005hi-TW for qemu-devel@nongnu.org; Tue, 16 Feb 2016 11:30:07 -0500 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:35560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aViVl-0005hR-Na for qemu-devel@nongnu.org; Tue, 16 Feb 2016 11:30:01 -0500 Received: by mail-wm0-x229.google.com with SMTP id c200so170518880wme.0 for ; Tue, 16 Feb 2016 08:30:01 -0800 (PST) Sender: Paolo Bonzini References: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> <1455470231-5223-6-git-send-email-pbonzini@redhat.com> <20160215185818.14c47ef5.cornelia.huck@de.ibm.com> <56C34414.90809@redhat.com> <20160216171530.6f335a81.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <56C34E87.2090101@redhat.com> Date: Tue, 16 Feb 2016 17:29:59 +0100 MIME-Version: 1.0 In-Reply-To: <20160216171530.6f335a81.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 16/02/2016 17:15, Cornelia Huck wrote: > Hm... this seems to guarantee that _start()/_stop() never runs > concurrently, doesn't it? Could we get rid of the ->starting/->stopping > flags as well? > > ...and ->disabled as well, since we try just once until we stop? Sounds like that, yes. Paolo