From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW2S1-0007jI-FZ for qemu-devel@nongnu.org; Wed, 17 Feb 2016 08:47:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW2Ry-0004o6-6G for qemu-devel@nongnu.org; Wed, 17 Feb 2016 08:47:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW2Ry-0004nx-0M for qemu-devel@nongnu.org; Wed, 17 Feb 2016 08:47:26 -0500 References: <1455712553-14974-1-git-send-email-ppandit@redhat.com> From: Eric Blake Message-ID: <56C479EC.3090802@redhat.com> Date: Wed, 17 Feb 2016 06:47:24 -0700 MIME-Version: 1.0 In-Reply-To: <1455712553-14974-1-git-send-email-ppandit@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xWqxui9o1gKuDrm67kpNMua5OOnnFjSos" Subject: Re: [Qemu-devel] [PATCH] net: minor indentation updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P , Qemu Developers Cc: Jason Wang , Prasad J Pandit This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xWqxui9o1gKuDrm67kpNMua5OOnnFjSos Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/17/2016 05:35 AM, P J P wrote: > From: Prasad J Pandit >=20 > Due indentation and braces were missing at places, added them. >=20 Cleaning up existing code is best done as part of a series that is otherwise touching the code; doing it in isolation makes 'git blame' attribute the wrong author for no good reason. > Signed-off-by: Prasad J Pandit > --- > net/checksum.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) >=20 > diff --git a/net/checksum.c b/net/checksum.c > index e51698c..a8c47e3 100644 > --- a/net/checksum.c > +++ b/net/checksum.c > @@ -38,8 +38,9 @@ uint32_t net_checksum_add_cont(int len, uint8_t *buf,= int seq) > =20 > uint16_t net_checksum_finish(uint32_t sum) > { > - while (sum>>16) > - sum =3D (sum & 0xFFFF)+(sum >> 16); > + while (sum>>16) { > + sum =3D (sum & 0xFFFF)+(sum >> 16); If we DO decide the touch-up is worth it, please add spaces around the binary + as part of the cleanup. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xWqxui9o1gKuDrm67kpNMua5OOnnFjSos Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxHnsAAoJEKeha0olJ0NqJMcIAKSnpqWHespWtbu2Cr2h813G bZxdaMzTW+WzlGZ5yKlbI5DbOvRT1+uwuurqWHa0FHQVbu+COlPv+IrtkrFnM+k9 /yfbNWB9pevOeJRVSeZr93ur/Ffz5W6IOGpWua5v5hcJTFZjEUwhjo1Tp3geMhgu s5avlSpl+UTOjr9yxdTopXihPEjxZ+bV8bumuwp22B9fvk9yh8KSR48HaDuiGBIA O9TogbNb3vfoj6MhfmYG/QjEeWQfUMVUCG9BdlxQqxgaU/pkVOJwwr+J7YeYb8HS 9AMNBF0nPa8K102BxRSJe7r1A6FnnQTkUfvnjBdif0iYTTJIu7pA9GsWqCOF8Mg= =90m2 -----END PGP SIGNATURE----- --xWqxui9o1gKuDrm67kpNMua5OOnnFjSos--