From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW5V0-00058B-RF for qemu-devel@nongnu.org; Wed, 17 Feb 2016 12:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW5Uv-0007iW-Se for qemu-devel@nongnu.org; Wed, 17 Feb 2016 12:02:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW5Uv-0007iC-NL for qemu-devel@nongnu.org; Wed, 17 Feb 2016 12:02:41 -0500 References: <1455727675-20625-1-git-send-email-marcandre.lureau@redhat.com> From: Laszlo Ersek Message-ID: <56C4A7AD.3030209@redhat.com> Date: Wed, 17 Feb 2016 18:02:37 +0100 MIME-Version: 1.0 In-Reply-To: <1455727675-20625-1-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/5] qga: win32 guest-set-user-password improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com On 02/17/16 17:47, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Hi, >=20 > Laszlo Ersek pointed out a few worthy improvements to the win32 > guest-set-user-password command. >=20 > Marc-Andr=C3=A9 Lureau (5): > qga: use more idiomatic qemu-style eol operators > qga: use size_t for wcslen() return value > qga: use wide-chars constants for wchar_t comparisons > qga: fix off-by-one length check > qga: check utf8-to-utf16 conversion >=20 > qga/commands-win32.c | 34 +++++++++++++++++++++++++--------- > 1 file changed, 25 insertions(+), 9 deletions(-) >=20 series Reviewed-by: Laszlo Ersek Thanks! Laszlo