From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWCCK-00065X-BZ for qemu-devel@nongnu.org; Wed, 17 Feb 2016 19:12:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWCCE-0003F2-NQ for qemu-devel@nongnu.org; Wed, 17 Feb 2016 19:11:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWCCE-0003Da-GU for qemu-devel@nongnu.org; Wed, 17 Feb 2016 19:11:50 -0500 References: <174e5d40f6c59bf57ea997c0575f21b8b67ce5d6.1455739133.git.alistair.francis@xilinx.com> <56C4E923.9000306@redhat.com> From: Eric Blake Message-ID: <56C50C43.7060201@redhat.com> Date: Wed, 17 Feb 2016 17:11:47 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tGKIXOBhoS5MuoIatLM1qr8RUd3QGvjae" Subject: Re: [Qemu-devel] [PATCH v1 2/2] generic-loader: Add a generic loader List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" , Peter Crosthwaite , Christopher Covington , Paolo Bonzini , lig.fnst@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tGKIXOBhoS5MuoIatLM1qr8RUd3QGvjae Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/17/2016 05:03 PM, Alistair Francis wrote: >>> +++ b/hw/misc/generic-loader.c >>> @@ -0,0 +1,127 @@ >>> +/* >>> + * Generic Loader >>> + * >>> + * Copyright (C) 2014 Li Guang >>> + * Written by Li Guang >> >> Want to claim 2016? >=20 > Yep, I can do that. I'm never too sure when this can be changed or > not. Should I add a written by as well? I'm not a lawyer, so my response may not be authoritative; in particular, your employer may have specific rules that you must follow for any code you submit that was written on your employer's time, and that trumps anything I say here (that is, trust your lawyers more than you trust me). But in general, I tend to go by the simple rule of listing the first year that any of the code was first developed (if you are copying significant portions from some other file, then use the starting year from that file, even if your file didn't exist back then), through the current year, if my change is non-trivial (more than 10 lines, or altering an interface), while ignoring the issue for trivial things (such as fixing a typo, or doing a bulk search-and-replace across the tree). As for an authorship line, I tend to omit those (they quickly go stale, and git history is sufficient for a much more accurate picture); the copyright line is more important legally than any author line. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tGKIXOBhoS5MuoIatLM1qr8RUd3QGvjae Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxQxDAAoJEKeha0olJ0NqloUH/AjGTb9dzrOJAarB5UmIFgmF YwH32BEtkJHAPlFRcAV5PGRE5cpj5w646OF+wxZh6SBlpe84fJb+dECVN471u73I VGJ743uMH2ANJ0g6vNnl15ajPXzLkMYm+Mg+z14xXOgQ1Lpp0EyEklRSHcEzogs1 JN79IMKOzKvb12Y1KszE7GuPpTNcUOMQcFZHWOOIrJ5EQDVF2ZUtTK2WzOWq+0TR seV0VAqduAchnGoxUCbC2y4OktGws0uHZ/pwpPYgzmCzVtGTbcyMBVA5pa9Xmnun pcBeRZPurN7KKATUSeUdC+C17i1kY0YCyAIOPTDNSdKfFuySKr+lA9al68ebGrA= =eOcr -----END PGP SIGNATURE----- --tGKIXOBhoS5MuoIatLM1qr8RUd3QGvjae--