From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aWMzC-0006nX-37
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 06:43:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aWMz8-0007k9-Q7
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 06:43:05 -0500
Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:57104)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aWMz8-0007jy-Gi
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 06:43:02 -0500
Received: from localhost
	by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <frankja@linux.vnet.ibm.com>;
	Thu, 18 Feb 2016 11:42:59 -0000
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7337917D805A
	for <qemu-devel@nongnu.org>; Thu, 18 Feb 2016 11:43:16 +0000 (GMT)
Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com
	[9.149.37.252])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u1IBgvUC8126810
	for <qemu-devel@nongnu.org>; Thu, 18 Feb 2016 11:42:57 GMT
Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u1IBgvoQ001572
	for <qemu-devel@nongnu.org>; Thu, 18 Feb 2016 04:42:57 -0700
References: <1455689899-31227-1-git-send-email-famz@redhat.com>
From: Janosch Frank <frankja@linux.vnet.ibm.com>
Message-ID: <56C5AE40.6080809@linux.vnet.ibm.com>
Date: Thu, 18 Feb 2016 12:42:56 +0100
MIME-Version: 1.0
In-Reply-To: <1455689899-31227-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right
	parantheses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, frankja@linux.vnet.ibm.com

On 02/17/2016 07:18 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  scripts/kvm/kvm_stat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..517fbec 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -800,7 +800,7 @@ def check_access(options):
>          if options.tracepoints:
>              sys.exit(1)
> 
> -        sys.stderr.write("Falling back to debugfs statistics!\n"
> +        sys.stderr.write("Falling back to debugfs statistics!\n")
>          options.debugfs = True
>          sleep(5)
> 
Thanks for fixing that.
If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the
write a few lines above, go ahead.

I should have been more careful when reading the pull mail from Paolo.
The affected lines are not my code and definitely not my v2 which
included the "exit if -t is passed explicitly" that Paolo added to my
commit.