Re: [Qemu-devel] [PATCH 5/8] spice: add opengl/virgl/dmabuf support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On 02/18/2016 02:26 AM, Gerd Hoffmann wrote:
> This adds support for dma-buf passing to spice.  This makes virtio-gpu
> with 3d acceleration work with spice.
> 

> 
> gl mode is turned off by default, use "-spice gl=on,$otherargs" to
> enable it.
> 

>  
> @@ -494,9 +497,14 @@ static QemuOptsList qemu_spice_opts = {
>          },{
>              .name = "playback-compression",
>              .type = QEMU_OPT_BOOL,
> -        }, {
> +        },{
>              .name = "seamless-migration",
>              .type = QEMU_OPT_BOOL,
> +#ifdef CONFIG_OPENGL_DMABUF
> +        },{
> +            .name = "gl",
> +            .type = QEMU_OPT_BOOL,
> +#endif
>          },

How introspectible is this? Does QMP 'query-command-line-options' cope
will with showing 'gl' as an option only for the qemu binaries where the
#ifdef succeeded?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]