From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39492)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Hollis_Blanchard@mentor.com>) id 1aWTSL-0006Nd-7Y
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 13:37:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Hollis_Blanchard@mentor.com>) id 1aWTSG-0005kF-8J
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 13:37:37 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:63628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Hollis_Blanchard@mentor.com>) id 1aWTSG-0005k7-2F
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 13:37:32 -0500
References: <1455744555-22101-1-git-send-email-hollis_blanchard@mentor.com>
	<1455744555-22101-2-git-send-email-hollis_blanchard@mentor.com>
From: Hollis Blanchard <hollis_blanchard@mentor.com>
Message-ID: <56C60F69.40107@mentor.com>
Date: Thu, 18 Feb 2016 10:37:29 -0800
MIME-Version: 1.0
In-Reply-To: <1455744555-22101-2-git-send-email-hollis_blanchard@mentor.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from
 TB-access tracepoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: stefanha@redhat.com
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On 02/17/2016 01:29 PM, Hollis Blanchard wrote:
> diff --git a/trace-events b/trace-events
> index 756ce86..7994420 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1630,6 +1630,8 @@ memory_region_ops_read(int cpu_index, void *mr, uint64_t addr, uint64_t value, u
>   memory_region_ops_write(int cpu_index, void *mr, uint64_t addr, uint64_t value, unsigned size) "cpu %d mr %p addr %#"PRIx64" value %#"PRIx64" size %u"
>   memory_region_subpage_read(int cpu_index, void *mr, uint64_t offset, uint64_t value, unsigned size) "cpu %d mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
>   memory_region_subpage_write(int cpu_index, void *mr, uint64_t offset, uint64_t value, unsigned size) "cpu %d mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> +memory_region_ops_tb_read(int cpu_index, uint64_t addr, uint64_t value, unsigned size) "cpu %d addr %#"PRIx64" value %#"PRIx64" size %u"
> +memory_region_ops_tb_write(int cpu_index, uint64_t addr, uint64_t value, unsigned size) "cpu %d addr %#"PRIx64" value %#"PRIx64" size %u"

Actually, I'd like to rename these new tracepoints to 
"memory_region_tb_read/write", for consistency with 
"memory_region_subpage_read/write". I'll wait for other comments before 
re-submitting though.

Hollis Blanchard
Mentor Graphics Emulation Division